[clang-tidy] Ignore blank spaces between cast's ")" and its sub expr.

[hokein]

Summary

Before the change:

auto i = (Enum) 5; => auto i = static_cast<Enum>( 5);

After the change:

auto i = (Enum) 5; => auto i = static_cast<Enum>(5);

[alexfh]

Sorry, missed your patch somehow. LG with one nit.

clang-tidy/google/AvoidCStyleCastsCheck.cpp

139

Why is this only done on non-parenthesized expressions? Will (int) (b) turn into static_cast<int> (b) as well?

[alexfh]

You might want to commit this at some point ;]

[hokein]

Support more cases.

[hokein]

You might want to commit this at some point ;]

I somewhat forgot this minor patch.

clang-tidy/google/AvoidCStyleCastsCheck.cpp

139

Good point, I have updated the patch to cover more cases. Please take a look again.

[alexfh]

LG. Thanks!

clang-tidy/google/AvoidCStyleCastsCheck.cpp

StringRef DestTypeString =
                                CastExpr->getRParenLoc().getLocWithOffset(-1)),
                            SM, getLangOpts());
 
   auto Diag =
       diag(CastExpr->getLocStart(), "C-style casts are discouraged; use %0");
 
   auto ReplaceWithCast = [&](std::string CastText) {
     const Expr *SubExpr = CastExpr->getSubExprAsWritten()->IgnoreImpCasts();
+    auto ReplaceRange = ParenRange;
     if (!isa<ParenExpr>(SubExpr)) {
       CastText.push_back('(');
       Diag << FixItHint::CreateInsertion(
           Lexer::getLocForEndOfToken(SubExpr->getLocEnd(), 0, SM,
                                      getLangOpts()),
           ")");
+      ReplaceRange = CharSourceRange::getCharRange(CastExpr->getLParenLoc(),
+                                                   SubExpr->getLocStart());
     }
-    Diag << FixItHint::CreateReplacement(ParenRange, CastText);
+    Diag << FixItHint::CreateReplacement(ReplaceRange, CastText);
   };
   auto ReplaceWithNamedCast = [&](StringRef CastType) {
     Diag << CastType;
     ReplaceWithCast((CastType + "<" + DestTypeString + ">").str());
   };
 
   // Suggest appropriate C++ cast. See [expr.cast] for cast notation semantics.
   switch (CastExpr->getCastKind()) {

test/clang-tidy/google-readability-casting.cpp

void f(int a, double b, const char *cpc, const void *cpv, X *pX) {
 
   int b1 = (int)b;
   // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: {{.*}}; use static_cast [
   // CHECK-FIXES: int b1 = static_cast<int>(b);
   b1 = (const int&)b;
   // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [
   // CHECK-FIXES: b1 = (const int&)b;
 
+  b1 = (int) b;
+  // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: {{.*}}; use static_cast {{.*}}
+  // CHECK-FIXES: b1 = static_cast<int>(b);
+
+  b1 = (int)         b;
+  // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: {{.*}}; use static_cast {{.*}}
+  // CHECK-FIXES: b1 = static_cast<int>(b);
+
   Y *pB = (Y*)pX;
   // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [
   Y &rB = (Y&)*pX;
   // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [
 
   const char *pc3 = (const char*)cpv;
   // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: {{.*}}; use static_cast [
   // CHECK-FIXES: const char *pc3 = static_cast<const char*>(cpv);