This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Start defining a calling convention
ClosedPublic

Authored by arsenm on Mar 28 2017, 2:05 PM.

Details

Reviewers
kzhuravl
tstellar
Summary

Partially implement callee-side for arguments and return values.
byval doesn't work properly, and most likely sret or other on-stack
return values most as well.

Diff Detail

Event Timeline

arsenm created this revision.Mar 28 2017, 2:05 PM
arsenm updated this revision to Diff 94131.Apr 4 2017, 3:25 PM
arsenm updated this revision to Diff 95508.Apr 17 2017, 4:56 PM

Change SP handling

arsenm updated this revision to Diff 98038.May 5 2017, 4:37 PM

Change SP handling

tstellar accepted this revision.May 16 2017, 8:03 AM
tstellar added a subscriber: tstellar.

This looks OK to me. Is the calling convention defined here still experimental, or is it going to remain stable for a long time?

This revision is now accepted and ready to land.May 16 2017, 8:03 AM

This looks OK to me. Is the calling convention defined here still experimental, or is it going to remain stable for a long time?

Still very experimental.

arsenm closed this revision.May 17 2017, 3:10 PM

r303308