This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix lldb build on musl
ClosedPublic

Authored by raj.khem on Mar 22 2017, 10:44 PM.

Download Raw Diff

Details

Reviewers

Commits

rG691e92b573ce: [lldb] Fix lldb build on musl
rL340876: [lldb] Fix lldb build on musl
rLLDB340876: [lldb] Fix lldb build on musl

Summary

limits.h is needed for getting PATH_MAX definition, this comes to fore with musl libc where limits.h is not included indirectly via other system headers.

Diff Detail

Event Timeline

raj.khem created this revision.Mar 22 2017, 10:44 PM

tatyana-krasnukha added a subscriber: tatyana-krasnukha.May 23 2017, 12:39 PM

tatyana-krasnukha removed a subscriber: tatyana-krasnukha.

Looks reasonable, limits.h really is not included by any of these system headers in musl.

raj.khem updated this revision to Diff 143455.Apr 21 2018, 9:46 AM

Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 21 2018, 9:46 AM

raj.khem retitled this revision from Fix lldb build on musl to [lldb] Fix lldb build on musl.Apr 21 2018, 9:50 AM

compnerd accepted this revision.Apr 22 2018, 7:38 PM

This revision is now accepted and ready to land.Apr 22 2018, 7:38 PM

Can someone with commit access push this for me please ?

Closed by commit rLLDB340876: [lldb] Fix lldb build on musl (authored by teemperor). · Explain WhyAug 28 2018, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Herald added subscribers: lldb-commits, abidh. · View Herald TranscriptAug 28 2018, 3:19 PM

Revision Contents

Path

Size

source/

Host/

common/

FileSpec.cpp

1 line

Diff 92758

source/Host/common/FileSpec.cpp

Context not available.
	#include <fstream>	#include <fstream>
	#include <set>	#include <set>
	#include <string.h>	#include <string.h>
		#include <limits.h>

	#include "lldb/Host/Config.h" // Have to include this before we test the define...	#include "lldb/Host/Config.h" // Have to include this before we test the define...
	#ifdef LLDB_CONFIG_TILDE_RESOLVES_TO_USER	#ifdef LLDB_CONFIG_TILDE_RESOLVES_TO_USER
Context not available.