Page MenuHomePhabricator

Add "(compatible with the GNU linker)" to the -version output.
ClosedPublic

Authored by ruiu on Mar 21 2017, 11:24 AM.

Event Timeline

ruiu created this revision.Mar 21 2017, 11:24 AM
silvas accepted this revision.Mar 21 2017, 12:27 PM
silvas added a subscriber: silvas.

Lgtm with a some suggestions that I don't feel too strongly about.

lld/ELF/Driver.cpp
320–324

Maybe say "linkers" since there is bfd and gold?

This revision is now accepted and ready to land.Mar 21 2017, 12:27 PM

Btw, I think this is one of the clearest proofs that LLD has crossed a big milestone and is now entering "production quality". You don't see this kind of hack in a non-production-quality program.

In a sense, this is an admission that LLD is reaching a point where it has an open-ended set of users "in the wild".

It is amazing how far we've come.

ruiu updated this revision to Diff 92534.Mar 21 2017, 1:27 PM

Make it plural. By the way, this patch reminds me why all major
browsers are still claiming that they are "Mozilla/5.0" in their
user-agent strings.

emaste edited edge metadata.Mar 21 2017, 2:03 PM

I'll follow up to my Jan 2017 libtool list posting about this issue with a link to this review. I hope that we can get some traction, such that this may be a short-term workaround rather than permanent descent into craziness like browser user agents.

emaste accepted this revision.EditedMar 21 2017, 4:08 PM
emaste added a subscriber: dim.

Although I'd rather not do this, I think it is a necessary workaround.

lld/test/ELF/driver.test
20

Suggested by @dim elsewhere, s/the //

It was suggested on the libtool mailing list that --with-gnu-ld to configure scripts might override libtool's tool --version string check and forcibly enable the GNU ld code path. I haven't yet tried this and won't be able to for a few days, but will take a look next week if nobody else does first.

This revision was automatically updated to reflect the committed changes.