Previous output:
$ ld.lld -version LLD 5.0.0
New output:
$ ld.lld -versin LLD 5.0.0 (compatible with the GNU linker)
Differential D31199
Add "(compatible with the GNU linker)" to the -version output. ruiu on Mar 21 2017, 11:24 AM. Authored by
Details Previous output: $ ld.lld -version LLD 5.0.0 New output: $ ld.lld -versin LLD 5.0.0 (compatible with the GNU linker)
Diff Detail
Event TimelineComment Actions Lgtm with a some suggestions that I don't feel too strongly about.
Comment Actions Btw, I think this is one of the clearest proofs that LLD has crossed a big milestone and is now entering "production quality". You don't see this kind of hack in a non-production-quality program. In a sense, this is an admission that LLD is reaching a point where it has an open-ended set of users "in the wild". It is amazing how far we've come. Comment Actions Make it plural. By the way, this patch reminds me why all major Comment Actions I'll follow up to my Jan 2017 libtool list posting about this issue with a link to this review. I hope that we can get some traction, such that this may be a short-term workaround rather than permanent descent into craziness like browser user agents. Comment Actions It was suggested on the libtool mailing list that --with-gnu-ld to configure scripts might override libtool's tool --version string check and forcibly enable the GNU ld code path. I haven't yet tried this and won't be able to for a few days, but will take a look next week if nobody else does first. |