Page MenuHomePhabricator

AMDGPU: Add all atomicrmw fields to atomic.inc/dec
ClosedPublic

Authored by arsenm on Mar 16 2017, 12:23 PM.

Details

Reviewers
kzhuravl
Summary

Add scope, order, isVolatile

Diff Detail

Event Timeline

arsenm created this revision.Mar 16 2017, 12:23 PM
t-tye added a subscriber: t-tye.Mar 22 2017, 6:40 PM
tony-tye removed a subscriber: tony-tye.Mar 22 2017, 6:47 PM
kzhuravl added inline comments.Mar 30 2017, 10:50 AM
include/llvm/IR/IntrinsicsAMDGPU.td
253–255

atomicrmw has these fields in the following order:
[volatile], [singlethread], <ordering>

should we mirror it in the same order?

arsenm added inline comments.Mar 30 2017, 10:55 AM
include/llvm/IR/IntrinsicsAMDGPU.td
253–255

In the text format volatile is placed before the normal pointer arguments, which I don't think we should do. It is a useful convention to keep the pointer argument first which matches loads

This revision is now accepted and ready to land.Mar 30 2017, 10:56 AM
arsenm closed this revision.Mar 30 2017, 3:35 PM

r299122