Page MenuHomePhabricator

TTI: Split IsSimple in MemIntrinsicInfo
ClosedPublic

Authored by arsenm on Mar 16 2017, 11:35 AM.

Details

Reviewers
hfinkel
Summary

All this did before was assert in EarlyCSE.

Diff Detail

Event Timeline

arsenm created this revision.Mar 16 2017, 11:35 AM
hfinkel accepted this revision.Mar 24 2017, 6:09 AM

LGTM

include/llvm/Analysis/TargetTransformInfo.h
59

While we're cleaning this up, can you remove this NumMemRefs variable? The interface is only useful if NumMemRefs is 1, and the structure only supports one PtrVal, so it is only usable if you set NumMemRefs to 1 (EarlyCSE aborts using this interface at all if NumMemRefs != 1). If we were going to extend it to support multiple memory references, we'd probably need a vector of something, and then we'd get this number from the size of the vector. Thus, this NumMemRefs will likely never be needed.

This revision is now accepted and ready to land.Mar 24 2017, 6:09 AM
arsenm closed this revision.Mar 24 2017, 12:09 PM

r298724