Page MenuHomePhabricator

[ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands
ClosedPublic

Authored by gerazo on Mar 10 2017, 8:24 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

gerazo created this revision.Mar 10 2017, 8:24 AM
whisperity added a subscriber: whisperity.

Hello Zoltan,
Thank you for the patch. There is an inline comment.

lib/AST/ASTImporter.cpp
5221 ↗(On Diff #91351)

In such cases, we should check that FromIdentifier is nullptr too (to detect cases where the result is nullptr due to import error). The check will be still present but will look like:

if (!ToII && S->getOutputIdentifier())
  return nullptr;

The same below.

szepet added a subscriber: szepet.Mar 13 2017, 2:36 AM
gerazo updated this revision to Diff 91541.Mar 13 2017, 5:31 AM

Better check not letting a real import problem passing through

gerazo marked an inline comment as done.Mar 13 2017, 5:32 AM
gerazo added inline comments.
lib/AST/ASTImporter.cpp
5221 ↗(On Diff #91351)

Thank you Aleksei, done.

gerazo marked an inline comment as done.Mar 13 2017, 5:33 AM
a.sidorin accepted this revision.Mar 13 2017, 8:08 AM

Looks good, thank you!

This revision is now accepted and ready to land.Mar 13 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.