... which applies a set of AtomicChanges on code.
Details
- Reviewers
klimek djasper - Commits
- rG7ef3a19337c6: Added `applyAtomicChanges` function.
rGea5c4a7ca3a8: Added `applyAtomicChanges` function.
rC309548: Added `applyAtomicChanges` function.
rC298913: Added `applyAtomicChanges` function.
rL309548: Added `applyAtomicChanges` function.
rL298913: Added `applyAtomicChanges` function.
Diff Detail
- Build Status
Buildable 5124 Build 5124: arc lint + arc unit
Event Timeline
include/clang/Tooling/Refactoring/AtomicChange.h | ||
---|---|---|
129 | That part of the sentence doesn't parse. | |
132 | I'd add default values for everything that will otherwise be uninitialized. | |
147–149 | Why? | |
lib/Tooling/Refactoring/AtomicChange.cpp | ||
106 | Won't this be incorrect if the last line (no \n) is 1 over the column limit (due to EndPos = Code.size()-1 above)? |
include/clang/Tooling/Refactoring/AtomicChange.h | ||
---|---|---|
147–149 | Changes might have equivalent paths in different forms (e.g. relative or absolute), and checking canonical paths are dependent on file systems and the working directory, so I think this should be checked/handled in the user level. | |
lib/Tooling/Refactoring/AtomicChange.cpp | ||
106 | Yeah, that is a bug. Should be Code.size() then. |
include/clang/Tooling/Refactoring/AtomicChange.h | ||
---|---|---|
139 | Should probably be "exceeding the column limit". | |
lib/Tooling/Refactoring/AtomicChange.cpp | ||
91 | I think LLVM style is lowerCamelCase now, right? Here and below. | |
113 | nit: I'd move this down and just return {} for kNone. | |
127 | Remove braces? | |
151 | What is copying these vectors buying us? | |
164 | I'd remove the parentheses. | |
196 | Remove the braces of the for loops. |
Looks good.. Very nice :)
lib/Tooling/Refactoring/AtomicChange.cpp | ||
---|---|---|
102 | nit: remove braces (at least for consistency) |
cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h | ||
---|---|---|
19 ↗ | (On Diff #93232) | It requires clangFormat in LINK_LIBS. Fixed in r298921. |
This (rL298913) was reverted upstream due to cyclic dependency on GreenDragon bot. Investigating...
That part of the sentence doesn't parse.