[clang-tidy] Ignore substituted template types in modernize-use-nullptr check.

[malcolm.parsons]

test/clang-tidy/modernize-use-nullptr.cpp

252

vale -> value

[hokein]

typo: vale => value.

[xazax.hun]

test/clang-tidy/modernize-use-nullptr.cpp

252

It might be great to have a test case for:

template<typename T>
class TemplateClass {
 public:
  explicit TemplateClass(int a, T *default_value = 0) {}

[alexfh]

LG

[hokein]

Add more tests.

[xazax.hun]

test/clang-tidy/modernize-use-nullptr.cpp

254

Great! Thanks for adding this test. I have the impression we do want to warn and fix this case however. What do you think?

[hokein]

test/clang-tidy/modernize-use-nullptr.cpp

252

Good catch. Done.

[xazax.hun]

clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp

254 ↗

(On Diff #90694)

Maybe as a separate patch, but I think it might be worth to warn here. WDYT? (Sorry for the double post, the previous one is disappeared after the commit.)

[alexfh]

clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp

254 ↗

(On Diff #90694)

Seems reasonable, but probably not an extremely frequent case. Deserves a FIXME at least.

[hokein]

clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp

254 ↗

(On Diff #90694)

+1, patch are welcome.

clang-tidy/modernize/UseNullptrCheck.cpp

 /// \brief Create a matcher that finds implicit casts as well as the head of a
 /// sequence of zero or more nested explicit casts that have an implicit cast
 /// to null within.
 /// Finding sequences of explict casts is necessary so that an entire sequence
 /// can be replaced instead of just the inner-most implicit cast.
 StatementMatcher makeCastSequenceMatcher() {
   StatementMatcher ImplicitCastToNull = implicitCastExpr(
       anyOf(hasCastKind(CK_NullToPointer), hasCastKind(CK_NullToMemberPointer)),
+      unless(hasImplicitDestinationType(qualType(substTemplateTypeParmType()))),
       unless(hasSourceExpression(hasType(sugaredNullptrType()))));
 
   return castExpr(anyOf(ImplicitCastToNull,
                         explicitCastExpr(hasDescendant(ImplicitCastToNull))),
                   unless(hasAncestor(explicitCastExpr())))
       .bind(CastSequence);
 }
 

test/clang-tidy/modernize-use-nullptr.cpp

 };
 
 uint64 Hash(uint64 seed = 0) { return 0; }
 
 void f() {
   bool a;
   a = ZZ(Hash());
 }
+
+// Test on ignoring substituted template types.
+template<typename T>
+class TemplateClass {
+ public:
+  explicit TemplateClass(int a, T default_value = 0) {}
+
+  void h(T *default_value = 0) {}
+
+  void f(int* p = 0) {}
+// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: use nullptr
+// CHECK-FIXES: void f(int* p = nullptr) {}
+};
+
+void IgnoreSubstTemplateType() {
+  TemplateClass<int*> a(1);
+}