This is an archive of the discontinued LLVM Phabricator instance.

Move Log from Core -> Utility
ClosedPublic

Authored by zturner on Mar 2 2017, 5:31 PM.

Details

Summary

This looks like an enormous patch, but it's only because Log is so heavily used that it's #included from everywhere. This patch is almost a straight code move, the only thing that differs is that Log was depending on Host in a few places to get the thread id and thread name. Assuming I can land D30526, those calls are replaced with LLVM calls so that Log no longer has any dependency outside of Utility, and it can safely be lowered.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner created this revision.Mar 2 2017, 5:31 PM
labath accepted this revision.Mar 3 2017, 4:47 AM

I was building up to this, but I guess you beat me to it. :)

This revision is now accepted and ready to land.Mar 3 2017, 4:47 AM
This revision was automatically updated to reflect the committed changes.
lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp