Page MenuHomePhabricator

[DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen
AbandonedPublic

Authored by vleschuk on Feb 25 2017, 7:29 AM.

Details

Summary

When generating debug info collect information on calling convention for types (http://www.dwarfstd.org/ShowIssue.php?issue=141215.1) and pass it to backend.

Diff Detail

Event Timeline

dblaikie edited edge metadata.Feb 27 2017, 10:14 AM

Be best to avoid having to 'fixup' the argabi after the fact - and instead build the type with the right argabi from the get-go.

lib/CodeGen/CGDebugInfo.cpp
955–957

Could you file a bug/feature request with the DWARF committee? & maybe we could/should use an implementation defined extension value here? (assuming the DW_CC set has an implementation defined space - which I really hope it does)

test/CodeGenCXX/debug-info-type-calling-conventions.cpp
11–12

I'd probably make this a struct (and drop the 'public:' section since it'll be the default then) - since it doesn't seem to matter here.

vleschuk added inline comments.Feb 27 2017, 11:31 AM
test/CodeGenCXX/debug-info-type-calling-conventions.cpp
11–12
aprantl added inline comments.Feb 27 2017, 1:36 PM
lib/CodeGen/CGDebugInfo.cpp
955–957

Plenty:
DW_CC_lo_user 0x40
DW_CC_hi_user 0xff

vleschuk abandoned this revision.Jul 29 2018, 11:07 PM