This is an archive of the discontinued LLVM Phabricator instance.

Add lsan function stubs for darwin
ClosedPublic

Authored by fjricci on Feb 9 2017, 1:06 PM.

Details

Summary

This patch provides stubs for all of the lsan platform-specific
functions which need to be implemented for darwin. Currently
all of these functions are stubs, for the purpose of fixing
compilation.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci created this revision.Feb 9 2017, 1:06 PM
kubamracek edited edge metadata.Feb 10 2017, 2:33 PM

Can you insert something like CHECK(0 && "unimplemented") into all those functions? Just to make sure nobody actually tries to call them until they're implemented.

kubamracek added inline comments.Feb 10 2017, 2:47 PM
lib/lsan/lsan_common_mac.cc
11 ↗(On Diff #87862)

Please update comment.

lib/sanitizer_common/sanitizer_stoptheworld_mac.cc
10–11 ↗(On Diff #87862)

Please update comment.

fjricci updated this revision to Diff 88203.Feb 13 2017, 7:50 AM

Address comments

This revision is now accepted and ready to land.Feb 13 2017, 8:23 AM
This revision was automatically updated to reflect the committed changes.