This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][CMake] Use libc++ headers when available
ClosedPublic

Authored by phosek on Feb 5 2017, 10:16 PM.

Details

Summary

libunwind depends on C++ library headers. When building libunwind as part of LLVM and libc++ is available, use its headers.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Feb 5 2017, 10:16 PM
beanz added inline comments.Feb 8 2017, 11:29 AM
CMakeLists.txt
294 ↗(On Diff #87183)

I would name this variable with _DEFAULT on the end so that it is clear that you're setting the default value for a cached variable.

300 ↗(On Diff #87183)

Pretty sure include_directories can't be called with an empty string, so in the case where find_path fails, this could go wrong.

phosek updated this revision to Diff 87706.Feb 8 2017, 1:39 PM
phosek marked 2 inline comments as done.
beanz accepted this revision.Feb 8 2017, 1:41 PM

LGTM! Thanks!

This revision is now accepted and ready to land.Feb 8 2017, 1:41 PM
This revision was automatically updated to reflect the committed changes.