This is an archive of the discontinued LLVM Phabricator instance.

CMakeLists.txt
294	I would name this variable with `_DEFAULT` on the end so that it is clear that you're setting the default value for a cached variable.
300	Pretty sure `include_directories` can't be called with an empty string, so in the case where find_path fails, this could go wrong.

phosek updated this revision to Diff 87706.Feb 8 2017, 1:39 PM

phosek marked 2 inline comments as done.

LGTM! Thanks!

This revision is now accepted and ready to land.Feb 8 2017, 1:41 PM

Closed by commit rL294554: [libunwind][CMake] Use libc++ headers when available (authored by phosek). · Explain WhyFeb 8 2017, 6:32 PM

This revision was automatically updated to reflect the committed changes.

phosek mentioned this in D29800: [libunwind][CMake] Use libc++ headers when available.Feb 9 2017, 4:47 PM

Revision Contents

Path

Size

CMakeLists.txt

17 lines

Diff 87183

CMakeLists.txt

	Show First 20 Lines • Show All 276 Lines • ▼ Show 20 Lines
	endif()			endif()

	#===============================================================================			#===============================================================================
	# Setup Source Code			# Setup Source Code
	#===============================================================================			#===============================================================================

	include_directories(include)			include_directories(include)

				find_path(
				LIBUNWIND_LIBCXX_INCLUDES_INTERNAL
				__libcpp_version
				PATHS ${LLVM_MAIN_SRC_DIR}/projects/libcxx/include
				${LLVM_MAIN_SRC_DIR}/runtimes/libcxx/include
				NO_DEFAULT_PATH
				)
				if ((NOT LIBUNWIND_STANDALONE_BUILD OR HAVE_LIBCXX) AND
				IS_DIRECTORY "${LIBUNWIND_LIBCXX_INCLUDES_INTERNAL}")
				set(LIBUNWIND_CXX_INCLUDE_PATHS "${LIBUNWIND_LIBCXX_INCLUDES_INTERNAL}")
				beanzUnsubmitted Done Reply Inline Actions I would name this variable with `_DEFAULT` on the end so that it is clear that you're setting the default value for a cached variable. beanz: I would name this variable with `_DEFAULT` on the end so that it is clear that you're setting…
				endif()

				set(LIBUNWIND_CXX_INCLUDE_PATHS "${LIBUNWIND_CXX_INCLUDE_PATHS}" CACHE PATH
				"Paths to C++ header directories separated by ';'." FORCE)

				include_directories("${LIBUNWIND_CXX_INCLUDE_PATHS}")
				beanzUnsubmitted Done Reply Inline Actions Pretty sure `include_directories` can't be called with an empty string, so in the case where find_path fails, this could go wrong. beanz: Pretty sure `include_directories` can't be called with an empty string, so in the case where…

	add_subdirectory(src)			add_subdirectory(src)

This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][CMake] Use libc++ headers when availableClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 87183

CMakeLists.txt

[libunwind][CMake] Use libc++ headers when available
ClosedPublic