This is an archive of the discontinued LLVM Phabricator instance.

Move some classes from Core -> Utility
ClosedPublic

Authored by zturner on Feb 1 2017, 2:33 PM.

Details

Summary

NFC here, this only moves ConstString, Error, RegularExpression, Stream, and StreamString from Core to Utility. The CL is large because these headers are included in many places, so it required updating every include to point to the new location.

This change isn't very controversial, but it will require an update of the Xcode project. We can do that now so that I can submit this in one large patch, or I can just go in with this and someone can fix up the Xcode project later. LMK what is preferred.

Diff Detail

Event Timeline

zturner created this revision.Feb 1 2017, 2:33 PM
jingham accepted this revision.Feb 1 2017, 4:49 PM

This looks fine to me. Just check it on in and we'll fix the project files after the fact.

BTW, did you scrub the Host code and do the mutatis mutandis on them, or will we have to do that too?

This revision is now accepted and ready to land.Feb 1 2017, 4:49 PM

I didn't do everything needed to get Utility to be standalone if that's what you mean. Some things are trickier than others, so I wanted to isolate this CL to strictly mechanical code move.

What Host code were you referring to?

BTW, I'll probably submit this tomorrow since I'm heading out soon and won't be around in case something breaks.

I meant the code in source/Host, but somehow missed the change to Host/macosx/Symbols.cpp on the first pass, so you probably did.

This revision was automatically updated to reflect the committed changes.
lldb/source/Core/SourceManager.cpp