This is an archive of the discontinued LLVM Phabricator instance.

Fixes to modernize-use-using
ClosedPublic

Authored by krystyna on Jan 29 2017, 11:08 AM.

Details

Summary
  • removed unnessacary namespaces
  • added option to print warning in macros
  • no fix for typedef with array
  • removed "void" word from functions with 0 parameters

Fixes some bugs from bug http://llvm.org/PR28334. Rest of bugs moved to new bug http://llvm.org/PR31793.

Diff Detail

Repository
rL LLVM

Event Timeline

krystyna created this revision.Jan 29 2017, 11:08 AM
Prazek edited edge metadata.Jan 29 2017, 11:29 AM

Please mention in comments which bugs it solves. Also mention this review in the bugs on buganizer.
after fixing the nits, it LGTM, but wait for Alex approval.

clang-tidy/modernize/UseUsingCheck.cpp
99

Start with space and capital letter, end with dot.

clang-tidy/modernize/UseUsingCheck.h
24

please move it under the functions declarations, adding private:

28

probably move it to source file to keep convention.

krystyna updated this revision to Diff 86298.Jan 30 2017, 9:07 AM
krystyna edited the summary of this revision. (Show Details)

Style fixes.

krystyna marked 3 inline comments as done.Jan 30 2017, 9:08 AM
alexfh edited the summary of this revision. (Show Details)Feb 9 2017, 7:40 AM
alexfh accepted this revision.Feb 9 2017, 7:49 AM

LG with a few comments.

clang-tidy/modernize/UseUsingCheck.h
24

nit: empty line

35

nit: MacroWarning doesn't sound right to me. Maybe WarnInMacros or even IgnoreMacros (defaulting to true)?

test/clang-tidy/modernize-use-using.cpp
154

Why no trailing semicolon?

This revision is now accepted and ready to land.Feb 9 2017, 7:49 AM

Krystyna, do you need help committing the patch after you address the outstanding comments?

I have plan to finish this patch next week, when I finish academic year at my school. If I will have any issues with submitting, Prazek offered to help me.

I have plan to finish this patch next week, when I finish academic year at my school. If I will have any issues with submitting, Prazek offered to help me.

Sure, no stress. Good luck with your studies!

krystyna updated this revision to Diff 93797.Apr 2 2017, 9:51 AM
krystyna marked 2 inline comments as done.
krystyna marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.