[ARM] Remove ubig32_t cast from ARMAttributeParser

[samparker]

Summary

Multiple buildbots are failing to cast ubig32_t (no conversion from 'const llvm::support::ubig32_t' to 'const llvm::support::ulittle32_t) so i'm removing it.

[RKSimon]

lib/Support/ARMAttributeParser.cpp

689 ↗

(On Diff #84275)

If you replace the ternary operator with an if - else pair - then MSVC would be happy with the casts and you keep endian support

[samparker]

lib/Support/ARMAttributeParser.cpp

689 ↗

(On Diff #84275)

ah, ok! thanks!

[samparker]

Re-adding ubig32_t, but now using if/else to select the cast.

[bkramer]

can we just use support::endian::read32le and support::endian::read32be instead of the casting magic? They do the same thing but should have no problem with implicit conversions in a ternary expression.

[samparker]

this works for me.

[samparker]

Now using read32le and read32be to access memory. Also included a small fix for attribute printing.

[RKSimon]

In D28669#645173, @bkramer wrote:

can we just use support::endian::read32le and support::endian::read32be instead of the casting magic? They do the same thing but should have no problem with implicit conversions in a ternary expression.

Confirmed - this works fine too.

[RKSimon]

lib/Support/ARMAttributeParser.cpp

680 ↗

(On Diff #84290)

This seems unnecessary - or at least is a different problem.

691 ↗

(On Diff #84290)

clang-format

[samparker]

removed the extra bug fix and will upload as separate patch. clang-formatted the remaining.

[RKSimon]

LGTM - thanks

llvm/trunk/lib/Support/ARMAttributeParser.cpp

void ARMAttributeParser::ParseSubsection(const uint8_t *Data, uint32_t Length) {
   }
 }
 
 void ARMAttributeParser::Parse(ArrayRef<uint8_t> Section, bool isLittle) {
   size_t Offset = 1;
   unsigned SectionNumber = 0;
 
   while (Offset < Section.size()) {
-    uint32_t SectionLength = isLittle ?
-      *reinterpret_cast<const support::ulittle32_t*>(Section.data() + Offset) :
-      *reinterpret_cast<const support::ubig32_t*>(Section.data() + Offset);
+    uint32_t SectionLength =
+        isLittle ? support::endian::read32le(Section.data() + Offset)
+                 : support::endian::read32be(Section.data() + Offset);
 
     if (SW) {
       SW->startLine() << "Section " << ++SectionNumber << " {\n";
       SW->indent();
     }
 
     ParseSubsection(Section.data() + Offset, SectionLength);
     Offset = Offset + SectionLength;