This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Remove a redundant check. NFC
ClosedPublic

Authored by haicheng on Dec 20 2016, 2:44 PM.

Reviewers

Commits

Summary

The case AM.Scale == 0 is already handled by the code right above.

haicheng retitled this revision from to [AArch64] Remove a redundant check. NFC.

haicheng updated this object.

haicheng set the repository for this revision to rL LLVM.

haicheng added a subscriber: llvm-commits.

Seems legit.

This revision is now accepted and ready to land.Dec 20 2016, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Target/

AArch64/

3 lines

Show First 20 Lines • Show All 7,445 Lines • ▼ Show 20 Lines	if (NumBytes && Offset > 0 && (Offset / NumBytes) <= (1LL << 12) - 1 &&
// Must be a multiple of NumBytes (NumBytes is a power of 2)		// Must be a multiple of NumBytes (NumBytes is a power of 2)
(Offset >> shift) << shift == Offset)		(Offset >> shift) << shift == Offset)
return true;		return true;
return false;		return false;
}		}

// Check reg1 + SIZE_IN_BYTES * reg2 and reg1 + reg2		// Check reg1 + SIZE_IN_BYTES * reg2 and reg1 + reg2

return !AM.Scale \|\| AM.Scale == 1 \|\|		return AM.Scale == 1 \|\| (AM.Scale > 0 && (uint64_t)AM.Scale == NumBytes);
(AM.Scale > 0 && (uint64_t)AM.Scale == NumBytes);
}		}

int AArch64TargetLowering::getScalingFactorCost(const DataLayout &DL,		int AArch64TargetLowering::getScalingFactorCost(const DataLayout &DL,
const AddrMode &AM, Type *Ty,		const AddrMode &AM, Type *Ty,
unsigned AS) const {		unsigned AS) const {
// Scaling factors are not free at all.		// Scaling factors are not free at all.
// Operands \| Rt Latency		// Operands \| Rt Latency
// -------------------------------------------		// -------------------------------------------
▲ Show 20 Lines • Show All 3,172 Lines • Show Last 20 Lines