This is an archive of the discontinued LLVM Phabricator instance.

[scudo] ARM32 support
ClosedPublic

Authored by cryptoad on Dec 19 2016, 2:59 PM.

Details

Summary

With the previous modifications, the code works on ARM32. The random shuffle
test is unsupported on 32-bit platforms for the moment and being marked as
such. There is no hardware support for the checksum computation yet, this will
come at a later point.

Diff Detail

Repository
rL LLVM

Event Timeline

cryptoad updated this revision to Diff 82022.Dec 19 2016, 2:59 PM
cryptoad retitled this revision from to [scudo] ARM32 support.
cryptoad updated this object.
cryptoad added a subscriber: llvm-commits.
This revision was automatically updated to reflect the committed changes.

Hi Kostya,

What's the point of adding a review if you're going to commit anyway?

http://llvm.org/docs/DeveloperPolicy.html#code-reviews

"once a patch is sent out for review, it needs an explicit “looks good” before it is submitted. Do not assume silent approval, or request active objections to the patch with a deadline."

cheers,
--renato

My apologies, I assumed it was benign enough. It won't happen again.