Details
Diff Detail
- Build Status
Buildable 2275 Build 2275: arc lint + arc unit
Event Timeline
llvm/include/llvm/ADT/APFloat.h | ||
---|---|---|
772–774 | Why aren't you doing the same transformation as before here? |
llvm/include/llvm/ADT/APFloat.h | ||
---|---|---|
772–774 | This will also work: if (usesLayout<IEEEFloat>(*U.semantics)) return U.IEEE.makeInf(Neg); if (usesLayout<DoubleAPFloat>(*U.semantics)) return U.Double.makeInf(Neg); llvm_unreachable("Unexpected semantics"); But @jtony have opinions on returning an expression as void in D27872, and suggested removing the void. I'm slightly in favor of the early return version, since it's more consistent with other places; but I didn't have many data points from others. I'm happy to change. |
llvm/include/llvm/ADT/APFloat.h | ||
---|---|---|
772–774 | This seems both more compact, and consistent with the other cases, so it has my preference. |
Why aren't you doing the same transformation as before here?