This is an archive of the discontinued LLVM Phabricator instance.

[asan] Don't skip instrumentation of masked load/store unless we've seen a full load/store on that pointer.
ClosedPublic

Authored by filcab on Dec 9 2016, 11:41 AM.

Event Timeline

filcab updated this revision to Diff 80924.Dec 9 2016, 11:41 AM
filcab retitled this revision from to [asan] Don't skip instrumentation of masked load/store unless we've seen a full load/store on that pointer..
filcab updated this object.
filcab added reviewers: kcc, vitalybuka, pgousseau, RKSimon.
filcab added a subscriber: llvm-commits.
RKSimon added inline comments.Dec 10 2016, 3:45 PM
lib/Transforms/Instrumentation/AddressSanitizer.cpp
2074

Remove the braces. Any reason why you don't want to merge the if conditions?

filcab added inline comments.Dec 12 2016, 6:20 AM
lib/Transforms/Instrumentation/AddressSanitizer.cpp
2074

Mostly to avoid touching much code. I'll upload a new version.
But I'll keep the braces so we don't have ambiguity with the nested if (after the code change).

filcab updated this revision to Diff 81080.Dec 12 2016, 6:20 AM

Merge ifs.

kcc added inline comments.Dec 14 2016, 10:50 AM
lib/Transforms/Instrumentation/AddressSanitizer.cpp
2072

I'd expect this to be inside if (ClOpt && ClOptSameTemp)
No?

filcab planned changes to this revision.Dec 14 2016, 10:51 AM
filcab added inline comments.
lib/Transforms/Instrumentation/AddressSanitizer.cpp
2072

Ah! Right. Will submit new version.

filcab updated this revision to Diff 81425.Dec 14 2016, 11:08 AM

Fixed test

kcc accepted this revision.Dec 14 2016, 12:12 PM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 14 2016, 12:12 PM
This revision was automatically updated to reflect the committed changes.