This is an archive of the discontinued LLVM Phabricator instance.

Differential D27498

Add more tests for MSVC version handling.
ClosedPublic

Authored by dlj on Dec 6 2016, 6:08 PM.

Details

Reviewers
llvm-commits
rnk
Commits
rG62cd86863ac8: Add more tests for MSVC version handling.
rC288997: Add more tests for MSVC version handling.
rL288997: Add more tests for MSVC version handling.
Summary

This change adds more test cases for the default MSVC compatibility version:

  1. When -fms-extensions is supplied, but -fmsc-version and -fms-compatibility-version are not.
  2. With the target triple specifies an MSVC environment, but no other -fms* flags.

Diff Detail

Event Timeline

dlj updated this revision to Diff 80523.Dec 6 2016, 6:08 PM
dlj retitled this revision from to Add more tests for MSVC version handling..
dlj updated this object.
dlj added reviewers: rnk, llvm-commits.
dlj added subscribers: amccarth, compnerd, hans.
rnk accepted this revision.Dec 7 2016, 3:47 PM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Dec 7 2016, 3:47 PM
Closed by commit rL288997: Add more tests for MSVC version handling. (authored by dlj). · Explain WhyDec 7 2016, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Driver/
9 lines
2 lines

Diff 80523

test/Driver/msc-version.c

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
// CHECK-MSC-16-NOT: "-fmsc-version=1600" // CHECK-MSC-16-NOT: "-fmsc-version=1600"
// CHECK-MSC-16: "-fms-compatibility-version=16.0" // CHECK-MSC-16: "-fms-compatibility-version=16.0"
// RUN: %clang -### -target i686-windows -fms-compatibility -fmsc-version=150020706 -E - </dev/null -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MSC-15 // RUN: %clang -### -target i686-windows -fms-compatibility -fmsc-version=150020706 -E - </dev/null -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MSC-15
// CHECK-MSC-15-NOT: "-fmsc-version=150020706" // CHECK-MSC-15-NOT: "-fmsc-version=150020706"
// CHECK-MSC-15: "-fms-compatibility-version=15.0.20706" // CHECK-MSC-15: "-fms-compatibility-version=15.0.20706"
//
// Verify default version with -fms-extensions
//
// RUN: %clang -target i686-windows -fms-extensions -dM -E - </dev/null -o - | FileCheck %s -check-prefix CHECK-MS-EXTENSIONS
// CHECK-MS-EXTENSIONS: _MSC_BUILD 1
// CHECK-MS-EXTENSIONS: _MSC_FULL_VER {{..}}000000
// CHECK-MS-EXTENSIONS: _MSC_VER {{..}}00

test/Driver/msvc-triple.c

// RUN: %clang -target i686-pc-windows-msvc19 -S -emit-llvm %s -o - | FileCheck %s --check-prefix=TARGET-19 // RUN: %clang -target i686-pc-windows-msvc19 -S -emit-llvm %s -o - | FileCheck %s --check-prefix=TARGET-19
// RUN: %clang -target i686-pc-windows-msvc -S -emit-llvm %s -o - -fms-compatibility-version=19 | FileCheck %s --check-prefix=OVERRIDE-19 // RUN: %clang -target i686-pc-windows-msvc -S -emit-llvm %s -o - -fms-compatibility-version=19 | FileCheck %s --check-prefix=OVERRIDE-19
// RUN: %clang -target i686-pc-windows-msvc-elf -S -emit-llvm %s -o - | FileCheck %s --check-prefix=ELF-DEFAULT // RUN: %clang -target i686-pc-windows-msvc-elf -S -emit-llvm %s -o - | FileCheck %s --check-prefix=ELF-DEFAULT
// RUN: %clang -target i686-pc-windows-msvc -S -emit-llvm %s -o - | FileCheck %s --check-prefix=DEFAULT
// TARGET-19: target triple = "i686-pc-windows-msvc19.0.0" // TARGET-19: target triple = "i686-pc-windows-msvc19.0.0"
// OVERRIDE-19: target triple = "i686-pc-windows-msvc19.0.0" // OVERRIDE-19: target triple = "i686-pc-windows-msvc19.0.0"
// ELF-DEFAULT: target triple = "i686-pc-windows-msvc{{.*}}-elf" // ELF-DEFAULT: target triple = "i686-pc-windows-msvc{{.*}}-elf"
// DEFAULT: target triple = "i686-pc-windows-msvc{{[^-]+}}"