This is an archive of the discontinued LLVM Phabricator instance.

X86: Add checks for fma_patterns[_wide].ll with -enable-no-infs-fp-math
ClosedPublic

Authored by nhaehnle on Dec 2 2016, 8:19 AM.

Event Timeline

nhaehnle updated this revision to Diff 80073.Dec 2 2016, 8:19 AM
nhaehnle retitled this revision from to X86: Split fma_pattern[_wide].ll.
nhaehnle updated this object.
nhaehnle added reviewers: spatel, delena, craig.topper.
nhaehnle added a subscriber: llvm-commits.
RKSimon added a subscriber: RKSimon.

Why is this and D27347 better than just tweaking the check-prefixes?

Why is this and D27347 better than just tweaking the check-prefixes?

I went off the assumption that doubling the number of RUN lines on the whole file would increase the test time more than doubling it on just a part of the file. I admit that there's the possibility that process launch overhead dominates, and I didn't actually do the timing to test it. I don't feel strongly about it in any case.

RKSimon edited edge metadata.Dec 4 2016, 9:46 AM

I think overall it'll be better to just add extra test passes to the existing file, tweaking the check-prefixes as necessary.

nhaehnle updated this revision to Diff 80567.Dec 7 2016, 4:12 AM
nhaehnle edited edge metadata.

Don't split the files, just double the RUN lines in the existing files.

nhaehnle retitled this revision from X86: Split fma_pattern[_wide].ll to X86: Add checks for fma_patterns[_wide].ll with -enable-no-infs-fp-math.Dec 7 2016, 4:13 AM
nhaehnle updated this object.
RKSimon accepted this revision.Dec 7 2016, 5:18 AM
RKSimon edited edge metadata.

LGTM

test/CodeGen/X86/fma_patterns.ll
2

Delete this line - its a auto-generated leftover

This revision is now accepted and ready to land.Dec 7 2016, 5:18 AM
This revision was automatically updated to reflect the committed changes.