This is an archive of the discontinued LLVM Phabricator instance.

ELF/AArch64: Simplify R_AARCH64_ADD_ABS_LO12_NC relocation
ClosedPublic

Authored by zatrazz on Dec 1 2016, 10:05 AM.

Reviewers

Summary

This patch uses the updateAArch64Add on relocation apply and remove
the comment.

zatrazz retitled this revision from to ELF/AArch64: Simplify R_AARCH64_ADD_ABS_LO12_NC relocation.

zatrazz updated this object.

zatrazz set the repository for this revision to rL LLVM.

zatrazz added a project: lld.

zatrazz added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Dec 2 2016, 4:08 PM

Path

Size

ELF/

6 lines

Show First 20 Lines • Show All 1,331 Lines • ▼ Show 20 Lines	case R_AARCH64_PREL32:
write32le(Loc, Val);		write32le(Loc, Val);
break;		break;
case R_AARCH64_ABS64:		case R_AARCH64_ABS64:
case R_AARCH64_GLOB_DAT:		case R_AARCH64_GLOB_DAT:
case R_AARCH64_PREL64:		case R_AARCH64_PREL64:
write64le(Loc, Val);		write64le(Loc, Val);
break;		break;
case R_AARCH64_ADD_ABS_LO12_NC:		case R_AARCH64_ADD_ABS_LO12_NC:
// This relocation stores 12 bits and there's no instruction		updateAArch64Add(Loc, Val);
// to do it. Instead, we do a 32 bits store of the value
// of r_addend bitwise-or'ed Loc. This assumes that the addend
// bits in Loc are zero.
or32le(Loc, (Val & 0xFFF) << 10);
break;		break;
case R_AARCH64_ADR_GOT_PAGE:		case R_AARCH64_ADR_GOT_PAGE:
case R_AARCH64_ADR_PREL_PG_HI21:		case R_AARCH64_ADR_PREL_PG_HI21:
case R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21:		case R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21:
case R_AARCH64_TLSDESC_ADR_PAGE21:		case R_AARCH64_TLSDESC_ADR_PAGE21:
checkInt<33>(Loc, Val, Type);		checkInt<33>(Loc, Val, Type);
updateAArch64Addr(Loc, Val >> 12);		updateAArch64Addr(Loc, Val >> 12);
break;		break;
▲ Show 20 Lines • Show All 931 Lines • Show Last 20 Lines