This is an archive of the discontinued LLVM Phabricator instance.

Differential D27141

[asan] Support handle_sigill on Darwin
ClosedPublic

Authored by kubamracek on Nov 25 2016, 2:32 PM.

Details

Reviewers
kcc
dvyukov
eugenis
rnk
Commits
rG23551fa811fb: [asan] Support handle_sigill on Darwin
rCRT287959: [asan] Support handle_sigill on Darwin
rL287959: [asan] Support handle_sigill on Darwin
Summary

Handling SIGILL on Darwin works fine, so let's just make this feature work and re-enable the ill.cc testcase.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 79324.Nov 25 2016, 2:32 PM
kubamracek retitled this revision from to [asan] Support handle_sigill on Darwin.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, rnk, eugenis, kcc.
kubamracek set the repository for this revision to rL LLVM.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: zaks.anna, llvm-commits.
rnk accepted this revision.Nov 25 2016, 5:37 PM
rnk edited edge metadata.

nice, lgtm

This revision is now accepted and ready to land.Nov 25 2016, 5:37 PM
Closed by commit rL287959: [asan] Support handle_sigill on Darwin (authored by kuba.brecka). · Explain WhyNov 25 2016, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
2 lines
test/
asan/
TestCases/
1 line

Diff 79326

compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines
} }
bool IsHandledDeadlySignal(int signum) { bool IsHandledDeadlySignal(int signum) {
if ((SANITIZER_WATCHOS || SANITIZER_TVOS) && !(SANITIZER_IOSSIM)) if ((SANITIZER_WATCHOS || SANITIZER_TVOS) && !(SANITIZER_IOSSIM))
// Handling fatal signals on watchOS and tvOS devices is disallowed. // Handling fatal signals on watchOS and tvOS devices is disallowed.
return false; return false;
if (common_flags()->handle_abort && signum == SIGABRT) if (common_flags()->handle_abort && signum == SIGABRT)
return true; return true;
if (common_flags()->handle_sigill && signum == SIGILL)
return true;
return (signum == SIGSEGV || signum == SIGBUS) && common_flags()->handle_segv; return (signum == SIGSEGV || signum == SIGBUS) && common_flags()->handle_segv;
} }
MacosVersion cached_macos_version = MACOS_VERSION_UNINITIALIZED; MacosVersion cached_macos_version = MACOS_VERSION_UNINITIALIZED;
MacosVersion GetMacosVersionInternal() { MacosVersion GetMacosVersionInternal() {
int mib[2] = { CTL_KERN, KERN_OSRELEASE }; int mib[2] = { CTL_KERN, KERN_OSRELEASE };
char version[100]; char version[100];
▲ Show 20 Lines • Show All 438 Lines • Show Last 20 Lines

compiler-rt/trunk/test/asan/TestCases/ill.cc

// Test the handle_sigill option. // Test the handle_sigill option.
// //
// RUN: %clangxx_asan %s -o %t && %env_asan_opts=handle_sigill=0 not --crash %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0 // RUN: %clangxx_asan %s -o %t && %env_asan_opts=handle_sigill=0 not --crash %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
// RUN: %clangxx_asan %s -o %t && %env_asan_opts=handle_sigill=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1 // RUN: %clangxx_asan %s -o %t && %env_asan_opts=handle_sigill=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
// REQUIRES: x86-target-arch // REQUIRES: x86-target-arch
// UNSUPPORTED: darwin
#ifdef _WIN32 #ifdef _WIN32
#include <windows.h> #include <windows.h>
#endif #endif
int main(int argc, char **argv) { int main(int argc, char **argv) {
#ifdef _WIN32 #ifdef _WIN32
// Sometimes on Windows this test generates a WER fault dialog. Suppress that. // Sometimes on Windows this test generates a WER fault dialog. Suppress that.
Show All 18 Lines