Page MenuHomePhabricator

Merge Linux and FreeBSD arm register contexts
ClosedPublic

Authored by labath on Nov 25 2016, 3:10 AM.

Details

Summary

These two register contexts were identical, so this shouldn't cause any
regressions, but I'd appreciate it if you can check that this at least compiles.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 79287.Nov 25 2016, 3:10 AM
labath retitled this revision from to Merge Linux and FreeBSD arm register contexts.
labath updated this object.
labath added reviewers: emaste, sas.
labath added a subscriber: lldb-commits.
emaste edited edge metadata.Nov 25 2016, 8:31 AM
emaste added a subscriber: dmikulin.

I think @dmikulin might be able to test this

I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single step not a lot of tests pass on ARM FreeBSD ;)
Can we get D25756 committed?

I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single step not a lot of tests pass on ARM FreeBSD ;)
Can we get D25756 committed?

I'll leave that decision up to Ed.
I am not particularly fond of copying code around, but I do see the value of having some freebsd arm support instead of none.

As for this patch. A basic does-it-compile test should be enough, but I am pretty confident this is fine even without it, as I am just merging two identical files.

I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single step not a lot of tests pass on ARM FreeBSD ;)
Can we get D25756 committed?

I'll leave that decision up to Ed.
I am not particularly fond of copying code around, but I do see the value of having some freebsd arm support instead of none.

I'd be happy for D25756 to go in, but have a few comments added just now that should be addressed.

Just found this lying on the bottom of my stack. Ed, if you don't object, I'd like to check in it. I think it is quite a safe change, so we probably don't need to do too much testing.

This diff looks good and appreciated for other posix-like systems.

This revision was automatically updated to reflect the committed changes.