This is an archive of the discontinued LLVM Phabricator instance.

[ELF] FIxup buffer pointer before writing synthetic section
ClosedPublic

Authored by evgeny777 on Nov 22 2016, 10:05 AM.

Details

Summary

I think it makes sense to fix it now, because George (grimar) is preparing a patch allowing to use synthetic sections in linker script.
Normally this is done inside InputSection::writeTo, but synthetic sections were initially output sections and don't do this.

Diff Detail

Event Timeline

evgeny777 updated this revision to Diff 78887.Nov 22 2016, 10:05 AM
evgeny777 retitled this revision from to [ELF] FIxup buffer pointer before writing synthetic section.
evgeny777 updated this object.
evgeny777 added a reviewer: ruiu.
evgeny777 set the repository for this revision to rL LLVM.
evgeny777 added a project: lld.
evgeny777 added subscribers: grimar, ikudrin, llvm-commits.
ruiu accepted this revision.Nov 22 2016, 10:16 AM
ruiu edited edge metadata.

LGTM. Yeah, this is a big issue if we have multiple synthetic sections in an output section. Thank you for fixing.

This revision is now accepted and ready to land.Nov 22 2016, 10:16 AM

Thanks ! :)

This revision was automatically updated to reflect the committed changes.