[asan] Specialize the initialization-bug.cc testcase for Darwin (it needs a deployment target of 10.11+)

[kubamracek]

Summary

The ODR detection in initialization-bug.cc now works on Darwin (due to the recently enabled "live globals" on-by-default), but only if the deployment target is 10.11 or higher. Let's adjust the testcases.

[rnk]

Rather than duplicating the test, maybe we should add a lit substitution that expands to 10.11 deployment target?

[kubamracek]

In D26927#601704, @rnk wrote:

Rather than duplicating the test, maybe we should add a lit substitution that expands to 10.11 deployment target?

If I add "REQUIRES: osx10.11" the test won't be run on non-OSX platforms. Are you suggesting something else?

[rnk]

I'm suggesting this kind of thing:

// RUN: %clangxx_asan %mac_min_target_10.11 -O0 %s %p/../Helpers/initialization-bug-extra2.cc -o %t-INIT-ORDER-EXE
...
// UNSUPPORTED: osx-no-ld64-live_support

lit.common.cfg:

...
config.available_features.add('osx-ld64-live_support')
config.substitutions.append( ("%mac_min_target_10.11", "-mmacosx-version-min=10.11") )

[kubamracek]

Okay, sounds good. Updating the patch.

[rnk]

lgtm

compiler-rt/trunk/test/asan/TestCases/initialization-bug.cc

 // Test to make sure basic initialization order errors are caught.
 
-// RUN: %clangxx_asan -O0 %s %p/Helpers/initialization-bug-extra2.cc -o %t-INIT-ORDER-EXE
+// RUN: %clangxx_asan %macos_min_target_10_11 -O0 %s %p/Helpers/initialization-bug-extra2.cc -o %t-INIT-ORDER-EXE
 // RUN: %env_asan_opts=check_initialization_order=true not %run %t-INIT-ORDER-EXE 2>&1 | FileCheck %s
 
 // Do not test with optimization -- the error may be optimized away.
 
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=186
 // XFAIL: win32
 
 // The test is expected to fail on OS X Yosemite and older

compiler-rt/trunk/test/lit.common.cfg

else:
       # The ASAN initialization-bug.cc test should XFAIL on OS X systems
       # older than El Capitan. By marking the test as being unsupported with
       # this "feature", we can pass the test on newer OS X versions and other
       # platforms.
       config.available_features.add('osx-no-ld64-live_support')
   except:
     pass
 
+  config.substitutions.append( ("%macos_min_target_10_11", "-mmacosx-version-min=10.11") )
+else:
+  config.substitutions.append( ("%macos_min_target_10_11", "") )
+
 sancovcc_path = os.path.join(llvm_tools_dir, "sancov") 
 if os.path.exists(sancovcc_path):
   config.available_features.add("has_sancovcc")
   config.substitutions.append( ("%sancovcc ", sancovcc_path) )
 
 def is_darwin_lto_supported():
   return os.path.exists(os.path.join(config.llvm_shlib_dir, 'libLTO.dylib'))