This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Convert EhFrameHeader to input section
ClosedPublic

Authored by evgeny777 on Nov 21 2016, 2:38 AM.

Diff Detail

Event Timeline

evgeny777 updated this revision to Diff 78696.Nov 21 2016, 2:38 AM
evgeny777 retitled this revision from to [ELF] Convert EhFrameHeader to input section.
evgeny777 updated this object.
evgeny777 added reviewers: ruiu, rafael.
evgeny777 set the repository for this revision to rL LLVM.
evgeny777 added a project: lld.
evgeny777 added subscribers: ikudrin, grimar, llvm-commits.
grimar added inline comments.Nov 21 2016, 2:48 AM
ELF/SyntheticSections.cpp
39

I think it is not ordered. Because for example we have

using namespace llvm;
using namespace llvm::dwarf;
using namespace llvm::object;
using namespace llvm::support::endian;
using namespace llvm::ELF;

In OutputSections.cpp file, so looks we separate uppercase and lowercase elements.

ELF/Writer.cpp
986

Not sure if this is formatted (looks a bit strange in phab-view for me).

ruiu accepted this revision.Nov 21 2016, 6:20 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 21 2016, 6:20 AM
This revision was automatically updated to reflect the committed changes.