This is an archive of the discontinued LLVM Phabricator instance.

Differential D26715

[CMake] Error when LTO and lld are enabled on Darwin
ClosedPublic

Authored by phosek on Nov 15 2016, 4:30 PM.

Details

Reviewers
beanz
mehdi_amini
Commits
rGe4521c35230e: [CMake] Error when LTO and lld are enabled on Darwin
rL287256: [CMake] Error when LTO and lld are enabled on Darwin
Summary

lld on Darwin does not currently support LTO.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 78095.Nov 15 2016, 4:30 PM
phosek retitled this revision from to [CMake] Error when LTO and lld are enabled on Darwin.
phosek updated this object.
phosek added reviewers: mehdi_amini, beanz.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptNov 15 2016, 4:30 PM
phosek mentioned this in D26649: [CMake] Support lld with LTO bootstrap.Nov 15 2016, 4:31 PM
davide added a subscriber: davide.Nov 15 2016, 6:12 PM
davide added inline comments.
cmake/modules/HandleLLVMOptions.cmake
99–101

The change seems reasonable to me, but please wait for Chris to sign-off.
A shame lld still doesn't have LTO on Mach-O :(

beanz accepted this revision.Nov 16 2016, 3:50 PM
beanz edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Nov 16 2016, 3:50 PM
Closed by commit rL287256: [CMake] Error when LTO and lld are enabled on Darwin (authored by phosek). · Explain WhyNov 17 2016, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
modules/
3 lines

Diff 78095

cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
set(EXEEXT ${CMAKE_EXECUTABLE_SUFFIX}) set(EXEEXT ${CMAKE_EXECUTABLE_SUFFIX})
set(LTDL_SHLIB_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX}) set(LTDL_SHLIB_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
# We use *.dylib rather than *.so on darwin. # We use *.dylib rather than *.so on darwin.
set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX}) set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
if(APPLE) if(APPLE)
if(LLVM_ENABLE_LLD AND LLVM_ENABLE_LTO)
message(FATAL_ERROR "lld does not support LTO on Darwin")
endif()
davideUnsubmitted
Not Done
ReplyInline Actions

The change seems reasonable to me, but please wait for Chris to sign-off.
A shame lld still doesn't have LTO on Mach-O :(

davide: The change seems reasonable to me, but please wait for Chris to sign-off. A shame lld still…
# Darwin-specific linker flags for loadable modules. # Darwin-specific linker flags for loadable modules.
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress") set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress")
endif() endif()
# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO # Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO
# build might work on ELF but fail on MachO/COFF. # build might work on ELF but fail on MachO/COFF.
if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR
${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" OR ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" OR
▲ Show 20 Lines • Show All 580 Lines • Show Last 20 Lines