This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Handle f16 select{_cc}
ClosedPublic

Authored by kzhuravl on Nov 15 2016, 3:57 PM.

Details

Summary
  • Select select to v_cndmask_b32
  • Expand select_cc
  • Refactor patterns

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl updated this revision to Diff 78093.Nov 15 2016, 3:57 PM
kzhuravl retitled this revision from to [AMDGPU] Handle f16 select{_cc}.
kzhuravl updated this object.
kzhuravl added reviewers: tstellarAMD, arsenm.
kzhuravl added subscribers: b-sumner, llvm-commits.
arsenm accepted this revision.Nov 15 2016, 4:07 PM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/SIISelLowering.cpp
292 ↗(On Diff #78093)

Also should have a test for BR_CC, which probably also needs this

This revision is now accepted and ready to land.Nov 15 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.
kzhuravl added inline comments.Nov 15 2016, 7:26 PM
lib/Target/AMDGPU/SIISelLowering.cpp
292 ↗(On Diff #78093)

Thanks, I will do it in a follow up patch.