This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt from clang/runtime/CMakeLists.txt
ClosedPublic

Authored by kubamracek on Nov 11 2016, 12:39 PM.

Diff Detail

Event Timeline

kubamracek retitled this revision from to [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt from clang/runtime/CMakeLists.txt.
kubamracek updated this object.
kubamracek added a reviewer: beanz.
kubamracek set the repository for this revision to rL LLVM.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: llvm-commits, zaks.anna.
beanz accepted this revision.Nov 14 2016, 2:00 PM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Nov 14 2016, 2:00 PM
This revision was automatically updated to reflect the committed changes.
kubamracek reopened this revision.Nov 24 2016, 11:42 AM

I had to revert this, because the Swift bots then failed with a message from CMake saying that when CMAKE_OSX_DEPLOYMENT_TARGET is set, it also needs CMAKE_OSX_SYSROOT set (and on that bot machine, it couldn't find the sysroot on its own, although it can do that on my machine...).

This revision is now accepted and ready to land.Nov 24 2016, 11:42 AM
kubamracek requested a review of this revision.Nov 24 2016, 11:42 AM
kubamracek updated this revision to Diff 79250.
kubamracek edited edge metadata.
kubamracek removed rL LLVM as the repository for this revision.
kubamracek edited edge metadata.
beanz accepted this revision.Dec 15 2016, 11:14 AM
beanz edited edge metadata.

Ah! LGTM.

This revision is now accepted and ready to land.Dec 15 2016, 11:14 AM
This revision was automatically updated to reflect the committed changes.