This breaks some Swift builds, because Swift's build scripts explicitly set CMAKE_OSX_DEPLOYMENT_TARGET. This however isn't propagated to the compiler-rt build, causing build errors.
Details
Details
- Reviewers
beanz - Commits
- rG0c7c687b5b96: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when…
rGd71de87be737: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt…
rC289890: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when…
rC286898: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt…
rL289890: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when…
rL286898: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt…
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I had to revert this, because the Swift bots then failed with a message from CMake saying that when CMAKE_OSX_DEPLOYMENT_TARGET is set, it also needs CMAKE_OSX_SYSROOT set (and on that bot machine, it couldn't find the sysroot on its own, although it can do that on my machine...).