This is an archive of the discontinued LLVM Phabricator instance.

Make the Error class constructor protected
ClosedPublic

Authored by mehdi_amini on Nov 9 2016, 4:00 PM.

Event Timeline

mehdi_amini updated this revision to Diff 77416.Nov 9 2016, 4:00 PM
mehdi_amini retitled this revision from to Make the Error class constructor protected.
mehdi_amini updated this object.
mehdi_amini added a reviewer: lhames.
mehdi_amini added a subscriber: llvm-commits.
lhames accepted this revision.Nov 9 2016, 4:25 PM
lhames edited edge metadata.

LGTM. Thanks for this - it's a lot of leg-work!

  • Lang.
This revision is now accepted and ready to land.Nov 9 2016, 4:25 PM
pcc added a subscriber: pcc.Nov 9 2016, 4:26 PM
pcc added inline comments.
llvm/include/llvm/Support/Error.h
160

Might want to update this comment.

This revision was automatically updated to reflect the committed changes.