This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Show error location for 'duplicate symbol' error
ClosedPublic

Authored by evgeny777 on Nov 8 2016, 6:36 AM.

Details

Summary

This patch shows new and previous locations for duplicate symbol in a same way it's being done for undefined symbols

Diff Detail

Event Timeline

evgeny777 updated this revision to Diff 77187.Nov 8 2016, 6:36 AM
evgeny777 retitled this revision from to [ELF] Show error location for 'duplicate symbol' error.
evgeny777 updated this object.
evgeny777 added reviewers: ruiu, rafael.
evgeny777 set the repository for this revision to rL LLVM.
evgeny777 added a project: lld.
evgeny777 added subscribers: grimar, ikudrin, llvm-commits.
rafael accepted this revision.Nov 8 2016, 7:15 AM
rafael edited edge metadata.

LGTM

awesome, thanks!

This revision is now accepted and ready to land.Nov 8 2016, 7:15 AM
This revision was automatically updated to reflect the committed changes.
ruiu edited edge metadata.Nov 8 2016, 12:22 PM

This is very useful.

I had a chat with Sean during the LLVM dev meeting, and he pointed out that if we can provide a better error diagnostics than exiting linkers, this could be an incentive for people to switch to a new linker. I agreed. Thank you for your your work on improving diagnostics.