This is an archive of the discontinued LLVM Phabricator instance.

Remove redundant calls to std::string::data()
ClosedPublic

Authored by malcolm.parsons on Nov 3 2016, 4:12 AM.

Reviewers

Commits

Build Status

Buildable 1000
Build 1000: arc lint + arc unit

malcolm.parsons retitled this revision from to Remove redundant calls to std::string::data().

LGTM!

This revision is now accepted and ready to land.Nov 3 2016, 5:26 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Parse/

2 lines

Tooling/

Core/

2 lines

Show First 20 Lines • Show All 1,030 Lines • ▼ Show 20 Lines	IdentifierInfo *Parser::ParseObjCSelectorPiece(SourceLocation &SelectorLoc) {
case tok::exclaim:		case tok::exclaim:
case tok::exclaimequal:		case tok::exclaimequal:
case tok::pipepipe:		case tok::pipepipe:
case tok::pipeequal:		case tok::pipeequal:
case tok::caret:		case tok::caret:
case tok::caretequal: {		case tok::caretequal: {
std::string ThisTok(PP.getSpelling(Tok));		std::string ThisTok(PP.getSpelling(Tok));
if (isLetter(ThisTok[0])) {		if (isLetter(ThisTok[0])) {
IdentifierInfo *II = &PP.getIdentifierTable().get(ThisTok.data());		IdentifierInfo *II = &PP.getIdentifierTable().get(ThisTok);
Tok.setKind(tok::identifier);		Tok.setKind(tok::identifier);
SelectorLoc = ConsumeToken();		SelectorLoc = ConsumeToken();
return II;		return II;
}		}
return nullptr;		return nullptr;
}		}

case tok::identifier:		case tok::identifier:
▲ Show 20 Lines • Show All 2,657 Lines • Show Last 20 Lines

Show First 20 Lines • Show All 563 Lines • ▼ Show 20 Lines	llvm::Expected<std::string> applyAllReplacements(StringRef Code,
OS.flush();		OS.flush();
return Result;		return Result;
}		}

std::map<std::string, Replacements> groupReplacementsByFile(		std::map<std::string, Replacements> groupReplacementsByFile(
const std::map<std::string, Replacements> &FileToReplaces) {		const std::map<std::string, Replacements> &FileToReplaces) {
std::map<std::string, Replacements> Result;		std::map<std::string, Replacements> Result;
for (const auto &Entry : FileToReplaces) {		for (const auto &Entry : FileToReplaces) {
llvm::SmallString<256> CleanPath(Entry.first.data());		llvm::SmallString<256> CleanPath(Entry.first);
llvm::sys::path::remove_dots(CleanPath, /remove_dot_dot=/true);		llvm::sys::path::remove_dots(CleanPath, /remove_dot_dot=/true);
Result[CleanPath.str()] = std::move(Entry.second);		Result[CleanPath.str()] = std::move(Entry.second);
}		}
return Result;		return Result;
}		}

} // end namespace tooling		} // end namespace tooling
} // end namespace clang		} // end namespace clang