[clang-tidy] Change readability-redundant-member-init to get base type from constructor

[malcolm.parsons]

Summary

Fixes PR30835

[aaron.ballman]

This change is missing a test case.

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

Why is it more correct to use the CXXConstructExpr type information rather than the CXXCtorInitializer?

[malcolm.parsons]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

Something to do with templates and namespaces.

In the bug report, CXXCtorInitializer had type std::__1::bitset<128> and CXXConstructExpr had type std::bitset<MAX_SUBTARGET_FEATURES>.

I don't know why.

[aaron.ballman]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

I believe it's because __1 is an inline namespace, and the printing policy matters. IIRC, there's the SuppressUnwrittenScope policy data member, that if you set it to true, it won't print the inline or anonymous namespace when printing types.

We should understand why there's a difference before applying this change. I think using the CXXCtorInitializer's type is more correct than using the CXXConstructExpr's type (due to implicit type conversions). Given that the printing policy controls whether inline namespaces are printed, I would have expected these both to print without the inline namespace (the type changed, but not the printing policy) -- the fact that the behavior differs makes me worried there's a bug somewhere else and this fix is masking it.

[malcolm.parsons]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

The difference isn't just the scope; MAX_SUBTARGET_FEATURES became 128 too.

Looking at Sema::BuildMemInitializer() didn't help me.

[malcolm.parsons]

Add test.

[malcolm.parsons]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

The lookup of the base type has a Path with sugared type, but the Decl found has a canonical type.

[aaron.ballman]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

So then you get the same behavior by getting the canonical type from Init->getTypeSourceInfo()->getType()?

[malcolm.parsons]

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

The AST is:

|-CXXRecordDecl 0x3748ef8 <line:102:1, line:106:1> line:102:8 struct F8 definition
| |-public 'Foo::Template<N_THINGS>':'struct Foo::Bar::Template<5>'
| |-CXXRecordDecl 0x3749508 <col:1, col:8> col:8 implicit referenced struct F8
| `-CXXConstructorDecl 0x37495e0 <line:103:3, col:22> col:3 F8 'void (void)'
|   |-CXXCtorInitializer 'struct Foo::Bar::Template<5>'
|   | `-CXXConstructExpr 0x374b518 <col:10, col:19> 'Foo::Template<N_THINGS>':'struct Foo::Bar::Template<5>' 'void (void) throw()'
|   `-CompoundStmt 0x374b578 <col:21, col:22>

Init->getTypeSourceInfo()->getType() is Foo::Bar::Template<5>
Init->getTypeSourceInfo()->getType().getCanonicalType() is Foo::Bar::Template<5>
Construct->getType() is Foo::Template<N_THINGS>
Construct->getType().getCanonicalType() is Foo::Bar::Template<5>

I don't think there can be an implicit cast when constructing a base class.

[aaron.ballman]

LGTM!

clang-tidy/readability/RedundantMemberInitCheck.cpp

57 ↗

(On Diff #76309)

Ah, okay, I think I see what's going on now! Thank you for helping me to get there. ;-) I think this change is correct.

clang-tools-extra/trunk/clang-tidy/readability/RedundantMemberInitCheck.cpp

if (Construct->getNumArgs() == 0 ||
       Construct->getArg(0)->isDefaultArgument()) {
     if (Init->isAnyMemberInitializer()) {
       diag(Init->getSourceLocation(), "initializer for member %0 is redundant")
           << Init->getMember()
           << FixItHint::CreateRemoval(Init->getSourceRange());
     } else {
       diag(Init->getSourceLocation(),
            "initializer for base class %0 is redundant")
-          << Init->getTypeSourceInfo()->getType()
+          << Construct->getType()
           << FixItHint::CreateRemoval(Init->getSourceRange());
     }
   }
 }
 
 } // namespace readability
 } // namespace tidy
 } // namespace clang

clang-tools-extra/trunk/test/clang-tidy/readability-redundant-member-init.cpp

 // Multiple inheritance
 struct F7 : S, T {
   F7() : S(), T() {}
   // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: initializer for base class 'S' is redundant
   // CHECK-MESSAGES: :[[@LINE-2]]:15: warning: initializer for base class 'T' is redundant
   // CHECK-FIXES: F7()  {}
 };
 
+namespace Foo {
+inline namespace Bar {
+template <int N>
+struct Template {
+  Template() = default;
+  int i = N;
+};
+}
+}
+
+enum { N_THINGS = 5 };
+
+struct F8 : Foo::Template<N_THINGS> {
+  F8() : Template() {}
+  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: initializer for base class 'Foo::Template<N_THINGS>' is redundant
+  // CHECK-FIXES: F8()  {}
+};
+
 // Initializer not written
 struct NF1 {
   NF1() {}
   S f;
 };
 
 // Initializer doesn't call default constructor
 struct NF2 {