Page MenuHomePhabricator

[AMDGPU] Expand vector mulhu/mulhs
ClosedPublic

Authored by vpykhtin on Oct 28 2016, 8:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

vpykhtin updated this revision to Diff 76195.Oct 28 2016, 8:29 AM
vpykhtin retitled this revision from to [AMDGPU] Expand vector mulhu/mulhs .
vpykhtin updated this object.
vpykhtin added reviewers: arsenm, tstellarAMD.
vpykhtin set the repository for this revision to rL LLVM.
vpykhtin added a subscriber: nhaustov.

Can you also add test on mulhs?

arsenm added inline comments.Oct 28 2016, 11:19 AM
test/CodeGen/AMDGPU/scalarize-ops.ll
1–2 ↗(On Diff #76195)

This test looks like it should be moved into udiv.ll. Is there a simpler way to expose mulhs usage?

vpykhtin added inline comments.Oct 28 2016, 11:32 AM
test/CodeGen/AMDGPU/scalarize-ops.ll
1–2 ↗(On Diff #76195)

I'll try to find out, along with test on mulhs.

vpykhtin updated this revision to Diff 76423.Oct 31 2016, 9:16 AM
vpykhtin edited edge metadata.
vpykhtin removed rL LLVM as the repository for this revision.

added mulhs test and moved it to udiv.ll and sdiv.ll

It looks like div is the most stable way to expose mulhs/mulhu.

arsenm accepted this revision.Oct 31 2016, 5:28 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 31 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.