Import/update constants from the DWARF 5 public review draft document.

[aprantl]

Summary

I noticed two incompatible changes:

1. DW_AT_dwo_id was removed because the dwo_id was moved into the CU header. Note that the attribute value was reserved, so LLVM can continue to emit it without causing ambiguity for now.
2. The one change that could cause a problem here is that DW_AT_ranges_base has been replaced by DW_AT_rnglist_base.

David/Eric: Would merely renaming the constant break any existing DWARF (4) tooling?

[aprantl]

Signed off by echristo via mail.

[aprantl]

285421, 285444, 285448.

include/llvm/Support/Dwarf.h

enum Attribute : uint16_t {
   DW_AT_linkage_name = 0x6e,
 
   // New in DWARF 5:
   DW_AT_string_length_bit_size = 0x6f,
   DW_AT_string_length_byte_size = 0x70,
   DW_AT_rank = 0x71,
   DW_AT_str_offsets_base = 0x72,
   DW_AT_addr_base = 0x73,
-  DW_AT_ranges_base = 0x74,
-  DW_AT_dwo_id = 0x75,
+  DW_AT_rnglists_base = 0x74,
+  DW_AT_dwo_id = 0x75, ///< Retracted from DWARF 5.
   DW_AT_dwo_name = 0x76,
   DW_AT_reference = 0x77,
   DW_AT_rvalue_reference = 0x78,
   DW_AT_macros = 0x79,
+  DW_AT_call_all_calls = 0x7a,
+  DW_AT_call_all_source_calls = 0x7b,
+  DW_AT_call_all_tail_calls = 0x7c,
+  DW_AT_call_return_pc = 0x7d,
+  DW_AT_call_value = 0x7e,
+  DW_AT_call_origin = 0x7f,
+  DW_AT_call_parameter = 0x80,
+  DW_AT_call_pc = 0x81,
+  DW_AT_call_tail_call = 0x82,
+  DW_AT_call_target = 0x83,
+  DW_AT_call_target_clobbered = 0x84,
+  DW_AT_call_data_location = 0x85,
+  DW_AT_call_data_value = 0x86,
   DW_AT_noreturn = 0x87,
   DW_AT_alignment = 0x88,
+  DW_AT_export_symbols = 0x89,
+  DW_AT_deleted = 0x8a,
+  DW_AT_defaulted = 0x8b,
+  DW_AT_loclists_base = 0x8c,
 
   DW_AT_lo_user = 0x2000,
   DW_AT_hi_user = 0x3fff,
 
   DW_AT_MIPS_loop_begin = 0x2002,
   DW_AT_MIPS_tail_loop_begin = 0x2003,
   DW_AT_MIPS_epilog_begin = 0x2004,
   DW_AT_MIPS_loop_unroll_factor = 0x2005,
enum Form : uint16_t {
   DW_FORM_ref2 = 0x12,
   DW_FORM_ref4 = 0x13,
   DW_FORM_ref8 = 0x14,
   DW_FORM_ref_udata = 0x15,
   DW_FORM_indirect = 0x16,
   DW_FORM_sec_offset = 0x17,
   DW_FORM_exprloc = 0x18,
   DW_FORM_flag_present = 0x19,
+
+  // New in DWARF v5.
+  DW_FORM_strx = 0x1a,
+  DW_FORM_addrx = 0x1b,
+  DW_FORM_ref_sup = 0x1c,
+  DW_FORM_strp_sup = 0x1d,
+  DW_FORM_data16 = 0x1e,
+  DW_FORM_line_strp = 0x1f,
   DW_FORM_ref_sig8 = 0x20,
+  DW_FORM_implicit_const = 0x21,
+  DW_FORM_loclistx = 0x22,
+  DW_FORM_rnglistx = 0x23,
   
   DW_FORM_lo_user = 0x1f00,
   // Extensions for Fission proposal
   DW_FORM_GNU_addr_index = 0x1f01,
   DW_FORM_GNU_str_index = 0x1f02,
 
   // Alternate debug sections proposal (output of "dwz" tool).
   DW_FORM_GNU_ref_alt = 0x1f20,

include/llvm/Support/Dwarf.def

 HANDLE_DW_TAG(0x0041, type_unit)
 HANDLE_DW_TAG(0x0042, rvalue_reference_type)
 HANDLE_DW_TAG(0x0043, template_alias)
 
 // New in DWARF v5.
 HANDLE_DW_TAG(0x0044, coarray_type)
 HANDLE_DW_TAG(0x0045, generic_subrange)
 HANDLE_DW_TAG(0x0046, dynamic_type)
+HANDLE_DW_TAG(0x0047, atomic_type)
+HANDLE_DW_TAG(0x0048, call_site)
+HANDLE_DW_TAG(0x0049, call_site_parameter)
+HANDLE_DW_TAG(0x004a, skeleton_unit)
+HANDLE_DW_TAG(0x004b, immutable_type)
 
 // User-defined tags.
 HANDLE_DW_TAG(0x4081, MIPS_loop)
 HANDLE_DW_TAG(0x4101, format_label)
 HANDLE_DW_TAG(0x4102, function_template)
 HANDLE_DW_TAG(0x4103, class_template)
 HANDLE_DW_TAG(0x4106, GNU_template_template_param)
 HANDLE_DW_TAG(0x4107, GNU_template_parameter_pack)

 HANDLE_DW_OP(0x98, call2)
 HANDLE_DW_OP(0x99, call4)
 HANDLE_DW_OP(0x9a, call_ref)
 HANDLE_DW_OP(0x9b, form_tls_address)
 HANDLE_DW_OP(0x9c, call_frame_cfa)
 HANDLE_DW_OP(0x9d, bit_piece)
 HANDLE_DW_OP(0x9e, implicit_value)
 HANDLE_DW_OP(0x9f, stack_value)
+HANDLE_DW_OP(0xa0, implicit_pointer)
+HANDLE_DW_OP(0xa1, addrx)
+HANDLE_DW_OP(0xa2, constx)
+HANDLE_DW_OP(0xa3, entry_value)
+HANDLE_DW_OP(0xa4, const_type)
+HANDLE_DW_OP(0xa5, regval_type)
+HANDLE_DW_OP(0xa6, deref_type)
+HANDLE_DW_OP(0xa7, xderef_type)
+HANDLE_DW_OP(0xa8, convert)
+HANDLE_DW_OP(0xa9, reinterpret)
 
+// Vendor extensions.
 // Extensions for GNU-style thread-local storage.
 HANDLE_DW_OP(0xe0, GNU_push_tls_address)
 
 // Extensions for Fission proposal.
 HANDLE_DW_OP(0xfb, GNU_addr_index)
 HANDLE_DW_OP(0xfc, GNU_const_index)
 
 // DWARF languages.

 HANDLE_DW_LANG(0x001c, Rust)
 HANDLE_DW_LANG(0x001d, C11)
 HANDLE_DW_LANG(0x001e, Swift)
 HANDLE_DW_LANG(0x001f, Julia)
 HANDLE_DW_LANG(0x0020, Dylan)
 HANDLE_DW_LANG(0x0021, C_plus_plus_14)
 HANDLE_DW_LANG(0x0022, Fortran03)
 HANDLE_DW_LANG(0x0023, Fortran08)
+HANDLE_DW_LANG(0x0024, RenderScript)
+
+// Vendor extensions.
 HANDLE_DW_LANG(0x8001, Mips_Assembler)
 HANDLE_DW_LANG(0x8e57, GOOGLE_RenderScript)
 HANDLE_DW_LANG(0xb000, BORLAND_Delphi)
 
 // DWARF attribute type encodings.
 HANDLE_DW_ATE(0x01, address)
 HANDLE_DW_ATE(0x02, boolean)
 HANDLE_DW_ATE(0x03, complex_float)
 HANDLE_DW_ATE(0x04, float)
 HANDLE_DW_ATE(0x05, signed)
 HANDLE_DW_ATE(0x06, signed_char)
 HANDLE_DW_ATE(0x07, unsigned)
 HANDLE_DW_ATE(0x08, unsigned_char)
 HANDLE_DW_ATE(0x09, imaginary_float)
 HANDLE_DW_ATE(0x0a, packed_decimal)
 HANDLE_DW_ATE(0x0b, numeric_string)
 HANDLE_DW_ATE(0x0c, edited)
 HANDLE_DW_ATE(0x0d, signed_fixed)
 HANDLE_DW_ATE(0x0e, unsigned_fixed)
 HANDLE_DW_ATE(0x0f, decimal_float)
 HANDLE_DW_ATE(0x10, UTF)
+HANDLE_DW_ATE(0x11, UCS)
+HANDLE_DW_ATE(0x12, ASCII)
 
 // DWARF virtuality codes.
 HANDLE_DW_VIRTUALITY(0x00, none)
 HANDLE_DW_VIRTUALITY(0x01, virtual)
 HANDLE_DW_VIRTUALITY(0x02, pure_virtual)
 
 // DWARF calling convention codes.
 HANDLE_DW_CC(0x01, normal)
 HANDLE_DW_CC(0x02, program)
 HANDLE_DW_CC(0x03, nocall)
+HANDLE_DW_CC(0x04, pass_by_reference)
+HANDLE_DW_CC(0x05, pass_by_value)
 HANDLE_DW_CC(0x41, GNU_borland_fastcall_i386)
 HANDLE_DW_CC(0xb0, BORLAND_safecall)
 HANDLE_DW_CC(0xb1, BORLAND_stdcall)
 HANDLE_DW_CC(0xb2, BORLAND_pascal)
 HANDLE_DW_CC(0xb3, BORLAND_msfastcall)
 HANDLE_DW_CC(0xb4, BORLAND_msreturn)
 HANDLE_DW_CC(0xb5, BORLAND_thiscall)
 HANDLE_DW_CC(0xb6, BORLAND_fastcall)
 HANDLE_DW_CC(0xc0, LLVM_vectorcall)
 
 #undef HANDLE_DW_TAG
 #undef HANDLE_DW_OP
 #undef HANDLE_DW_LANG
 #undef HANDLE_DW_ATE
 #undef HANDLE_DW_VIRTUALITY
 #undef HANDLE_DW_CC

lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp

uint64_t DWARFDebugInfoEntryMinimal::getAttributeValueAsSectionOffset(
   Optional<uint64_t> Result = FormValue.getAsSectionOffset();
   return Result.hasValue() ? Result.getValue() : FailValue;
 }
 
 uint64_t
 DWARFDebugInfoEntryMinimal::getRangesBaseAttribute(const DWARFUnit *U,
                                                    uint64_t FailValue) const {
   uint64_t Result =
-      getAttributeValueAsSectionOffset(U, DW_AT_ranges_base, -1ULL);
+      getAttributeValueAsSectionOffset(U, DW_AT_rnglists_base, -1ULL);
   if (Result != -1ULL)
     return Result;
   return getAttributeValueAsSectionOffset(U, DW_AT_GNU_ranges_base, FailValue);
 }
 
 bool DWARFDebugInfoEntryMinimal::getLowAndHighPC(const DWARFUnit *U,
                                                  uint64_t &LowPC,
                                                  uint64_t &HighPC) const {

lib/DebugInfo/DWARF/DWARFUnit.cpp

if (!HasCUDie) {
     uint64_t BaseAddr =
         DieArray[0].getAttributeValueAsAddress(this, DW_AT_low_pc, -1ULL);
     if (BaseAddr == -1ULL)
       BaseAddr = DieArray[0].getAttributeValueAsAddress(this, DW_AT_entry_pc, 0);
     setBaseAddress(BaseAddr);
     AddrOffsetSectionBase = DieArray[0].getAttributeValueAsSectionOffset(
         this, DW_AT_GNU_addr_base, 0);
     RangeSectionBase = DieArray[0].getAttributeValueAsSectionOffset(
-        this, DW_AT_ranges_base, 0);
+        this, DW_AT_rnglists_base, 0);
     // Don't fall back to DW_AT_GNU_ranges_base: it should be ignored for
     // skeleton CU DIE, so that DWARF users not aware of it are not broken.
   }
 
   setDIERelations();
   return DieArray.size();
 }
 

lib/Support/Dwarf.cpp

StringRef llvm::dwarf::AttributeString(unsigned Attribute) {
   case DW_AT_const_expr:                 return "DW_AT_const_expr";
   case DW_AT_enum_class:                 return "DW_AT_enum_class";
   case DW_AT_linkage_name:               return "DW_AT_linkage_name";
   case DW_AT_string_length_bit_size:     return "DW_AT_string_length_bit_size";
   case DW_AT_string_length_byte_size:    return "DW_AT_string_length_byte_size";
   case DW_AT_rank:                       return "DW_AT_rank";
   case DW_AT_str_offsets_base:           return "DW_AT_str_offsets_base";
   case DW_AT_addr_base:                  return "DW_AT_addr_base";
-  case DW_AT_ranges_base:                return "DW_AT_ranges_base";
+  case DW_AT_rnglists_base:              return "DW_AT_rnglists_base";
   case DW_AT_dwo_id:                     return "DW_AT_dwo_id";
   case DW_AT_dwo_name:                   return "DW_AT_dwo_name";
   case DW_AT_reference:                  return "DW_AT_reference";
   case DW_AT_rvalue_reference:           return "DW_AT_rvalue_reference";
+  case DW_AT_macros:                     return "DW_AT_macros";
+  case DW_AT_call_all_calls:             return "DW_AT_call_all_calls";
+  case DW_AT_call_all_source_calls:      return "DW_AT_call_all_source_calls";
+  case DW_AT_call_all_tail_calls:        return "DW_AT_call_all_tail_calls";
+  case DW_AT_call_return_pc:             return "DW_AT_call_return_pc";
+  case DW_AT_call_value:                 return "DW_AT_call_value";
+  case DW_AT_call_origin:                return "DW_AT_call_origin";
+  case DW_AT_call_parameter:             return "DW_AT_call_parameter";
+  case DW_AT_call_pc:                    return "DW_AT_call_pc";
+  case DW_AT_call_tail_call:             return "DW_AT_call_tail_call";
+  case DW_AT_call_target:                return "DW_AT_call_target";   
+  case DW_AT_call_target_clobbered:      return "DW_AT_call_target_clobbered";
+  case DW_AT_call_data_location:         return "DW_AT_call_data_location";
+  case DW_AT_call_data_value:            return "DW_AT_call_data_value";
   case DW_AT_noreturn:                   return "DW_AT_noreturn";
-  case DW_AT_alignment:
-    return "DW_AT_alignment";
+  case DW_AT_alignment:                  return "DW_AT_alignment";
+  case DW_AT_export_symbols:             return "DW_AT_export_symbols";
+  case DW_AT_deleted:                    return "DW_AT_deleted";
+  case DW_AT_defaulted:                  return "DW_AT_defaulted";
+  case DW_AT_loclists_base:              return "DW_AT_loclists_base";
   case DW_AT_MIPS_loop_begin:            return "DW_AT_MIPS_loop_begin";
   case DW_AT_MIPS_tail_loop_begin:       return "DW_AT_MIPS_tail_loop_begin";
   case DW_AT_MIPS_epilog_begin:          return "DW_AT_MIPS_epilog_begin";
   case DW_AT_MIPS_loop_unroll_factor:    return "DW_AT_MIPS_loop_unroll_factor";
   case DW_AT_MIPS_software_pipeline_depth:
     return "DW_AT_MIPS_software_pipeline_depth";
   case DW_AT_MIPS_linkage_name:          return "DW_AT_MIPS_linkage_name";
   case DW_AT_MIPS_stride:                return "DW_AT_MIPS_stride";