This patch introduces updateDiscriminator to DILocation so that it can be directly called by AddDiscriminator. It also makes it easier to update the discriminator later.
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 798 Build 798: arc lint + arc unit
Event Timeline
include/llvm/IR/DebugInfoMetadata.h | ||
---|---|---|
1274 | "update" doesn't feel quite right. Would cloneWithDiscriminator() or something along those lines be any better? | |
1620 | We usually use auto if the type is obvious from the context. |
Comment Actions
Thanks for the quick review. Will hold this until tomorrow to see if other debug info maintainers have any comments about this API change.
"update" doesn't feel quite right. Would cloneWithDiscriminator() or something along those lines be any better?