This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Do not generate UMAAL instruction on thumbv7m target.
ClosedPublic

Authored by pftbest on Oct 21 2016, 6:05 PM.

Details

Summary

UMAAL is a DSP instruction and it is not available on thumbv7m (Cortex-M3) and thumbv6m (Cortex-M0+1) targets.

Also fix wrong CHECK prefix in longMAC.ll test.

Event Timeline

pftbest updated this revision to Diff 75518.Oct 21 2016, 6:05 PM
pftbest retitled this revision from to [ARM] Do not generate UMAAL instruction on thumbv7m target..
pftbest updated this object.
pftbest added reviewers: samparker, rengolin.
jmolloy accepted this revision.Oct 22 2016, 3:17 AM
jmolloy added a reviewer: jmolloy.
jmolloy added a subscriber: jmolloy.

Hi,

Thanks for this! I'm going to approve, but please could you add another test checking that the UMAAL *does* get generated when targetting Cortex-M4 which is V7M+DSP.

Thanks!

James

This revision is now accepted and ready to land.Oct 22 2016, 3:17 AM
pftbest updated this revision to Diff 75528.Oct 22 2016, 4:13 AM
pftbest edited edge metadata.

Added test for thumbv7em (Cortex-M4) target.

A thousand thanks. LGTM!

If anyone has svn access, please commit.

samparker edited edge metadata.Oct 27 2016, 1:58 AM

Sorry, didn't see this. Will do!

This revision was automatically updated to reflect the committed changes.

I think there is something wrong with the last line in the commit, looks like line ending is missing

I didn't make this change in my diff.

Thanks for the heads up, please see review: D26027