[tsan] Expose __tsan_ignore_thread_begin and __tsan_ignore_thread_end in TSan interface

[zaks.anna]

Summary

This patch is needed to implement the function attribute that disable TSan checking at run time. (See https://reviews.llvm.org/D25857, and https://reviews.llvm.org/D25858)

[dvyukov]

test/tsan/Darwin/release-dealloc-norace-objcpp.mm

28 ↗

(On Diff #75383)

I don't understand ordering of the patches.
This patch is required for the tsan pass patch.
But this test will only pass if the tsan pass patch is submitted.
I think you need to split this patch into 2 parts: one adds the interface functions, another adds tests. Otherwise tree will be broken at some point.

[zaks.anna]

test/tsan/Darwin/release-dealloc-norace-objcpp.mm

28 ↗

(On Diff #75383)

You are correct. I'll split the patch into 2 before committing.

[zaks.anna]

Split out the test file into a separate patch. The test file has been updated to contain more tests and use TSan test barriers. It's submitted for review at https://reviews.llvm.org/D26228.

compiler-rt/trunk/lib/tsan/rtl/tsan_interface.h

 
 SANITIZER_INTERFACE_ATTRIBUTE void __tsan_vptr_read(void **vptr_p);
 SANITIZER_INTERFACE_ATTRIBUTE
 void __tsan_vptr_update(void **vptr_p, void *new_val);
 
 SANITIZER_INTERFACE_ATTRIBUTE void __tsan_func_entry(void *call_pc);
 SANITIZER_INTERFACE_ATTRIBUTE void __tsan_func_exit();
 
+SANITIZER_INTERFACE_ATTRIBUTE void __tsan_ignore_thread_begin();
+SANITIZER_INTERFACE_ATTRIBUTE void __tsan_ignore_thread_end();
+
 SANITIZER_INTERFACE_ATTRIBUTE
 void __tsan_read_range(void *addr, unsigned long size);  // NOLINT
 SANITIZER_INTERFACE_ATTRIBUTE
 void __tsan_write_range(void *addr, unsigned long size);  // NOLINT
 
 // User may provide function that would be called right when TSan detects
 // an error. The argument 'report' is an opaque pointer that can be used to
 // gather additional information using other TSan report API functions.

compiler-rt/trunk/lib/tsan/rtl/tsan_interface_inl.h

 void __tsan_func_entry(void *pc) {
   FuncEntry(cur_thread(), (uptr)pc);
 }
 
 void __tsan_func_exit() {
   FuncExit(cur_thread());
 }
 
+void __tsan_ignore_thread_begin() {
+  ThreadIgnoreBegin(cur_thread(), CALLERPC);
+}
+
+void __tsan_ignore_thread_end() {
+  ThreadIgnoreEnd(cur_thread(), CALLERPC);
+}
+
 void __tsan_read_range(void *addr, uptr size) {
   MemoryAccessRange(cur_thread(), CALLERPC, (uptr)addr, size, false);
 }
 
 void __tsan_write_range(void *addr, uptr size) {
   MemoryAccessRange(cur_thread(), CALLERPC, (uptr)addr, size, true);
 }