This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Expose __tsan_ignore_thread_begin and __tsan_ignore_thread_end in TSan interface
ClosedPublic

Authored by zaks.anna on Oct 20 2016, 5:46 PM.

Diff Detail

Event Timeline

zaks.anna updated this revision to Diff 75383.Oct 20 2016, 5:46 PM
zaks.anna retitled this revision from to [tsan] Expose __tsan_ignore_thread_begin and __tsan_ignore_thread_end in TSan interface.
zaks.anna updated this object.
zaks.anna added reviewers: kcc, kubamracek, dvyukov.
zaks.anna added a subscriber: llvm-commits.
dvyukov added inline comments.Oct 30 2016, 6:53 PM
test/tsan/Darwin/release-dealloc-norace-objcpp.mm
28

I don't understand ordering of the patches.
This patch is required for the tsan pass patch.
But this test will only pass if the tsan pass patch is submitted.
I think you need to split this patch into 2 parts: one adds the interface functions, another adds tests. Otherwise tree will be broken at some point.

zaks.anna added inline comments.Oct 31 2016, 12:13 PM
test/tsan/Darwin/release-dealloc-norace-objcpp.mm
28

You are correct. I'll split the patch into 2 before committing.

zaks.anna updated this revision to Diff 76666.Nov 1 2016, 6:40 PM

Split out the test file into a separate patch. The test file has been updated to contain more tests and use TSan test barriers. It's submitted for review at https://reviews.llvm.org/D26228.

dvyukov accepted this revision.Nov 6 2016, 8:13 PM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2016, 8:13 PM
This revision was automatically updated to reflect the committed changes.