This is an archive of the discontinued LLVM Phabricator instance.

Deduplicate sets of replacements by file names.
ClosedPublic

Authored by ioeric on Oct 13 2016, 8:32 AM.

Details

Summary

If there are multiple <File, Replacements> pairs with the same file
path after removing dots, we only keep one pair (with path after dots being
removed) and discard the rest.

Event Timeline

ioeric updated this revision to Diff 74529.Oct 13 2016, 8:32 AM
ioeric retitled this revision from to Deduplicate sets of replacements by file names..
ioeric updated this object.
ioeric added a reviewer: djasper.
ioeric added subscribers: cfe-commits, bkramer, hokein.
ioeric updated this revision to Diff 74531.Oct 13 2016, 8:35 AM
  • Updated comments for RefactoringTool.
ioeric added inline comments.Oct 13 2016, 9:31 AM
include/clang/Tooling/Core/Replacement.h
233

This is dead code.

djasper accepted this revision.Oct 14 2016, 2:14 AM
djasper edited edge metadata.

I'd not rename the function. Otherwise looks good.

This revision is now accepted and ready to land.Oct 14 2016, 2:14 AM
ioeric updated this revision to Diff 74632.Oct 14 2016, 2:20 AM
ioeric edited edge metadata.
  • Change name to groupReplacementsByFile
ioeric updated this revision to Diff 74634.Oct 14 2016, 2:30 AM
This revision was automatically updated to reflect the committed changes.