This is an archive of the discontinued LLVM Phabricator instance.

Differential D25415

[lit] Remove unused TestingProgressDisplay attr
ClosedPublic

Authored by modocache on Oct 9 2016, 4:07 PM.

Details

Reviewers
echristo
beanz
• ddunbar
delcypher
Commits
rG3a0f79fb190a: [lit] Remove unused TestingProgressDisplay attr
rL283709: [lit] Remove unused TestingProgressDisplay attr
Summary

TestingProgressDisplay initializes its current attribute to None, but
never reads or writes the value again. Remove it.

Diff Detail

Event Timeline

modocache updated this revision to Diff 74087.Oct 9 2016, 4:07 PM
modocache retitled this revision from to [lit] Remove unused TestingProgressDisplay attr.
modocache updated this object.
modocache added reviewers: • ddunbar, echristo, delcypher, beanz.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptOct 9 2016, 4:07 PM
• ddunbar accepted this revision.Oct 9 2016, 5:03 PM
• ddunbar edited edge metadata.
This revision is now accepted and ready to land.Oct 9 2016, 5:03 PM
modocache closed this revision.Oct 9 2016, 6:29 PM

Revision Contents

PathSize
utils/
lit/
lit/
1 line

Diff 74087

utils/lit/lit/main.py

Show All 22 Lines
import lit.run import lit.run
import lit.util import lit.util
import lit.discovery import lit.discovery
class TestingProgressDisplay(object): class TestingProgressDisplay(object):
def __init__(self, opts, numTests, progressBar=None): def __init__(self, opts, numTests, progressBar=None):
self.opts = opts self.opts = opts
self.numTests = numTests self.numTests = numTests
self.current = None
self.progressBar = progressBar self.progressBar = progressBar
self.completed = 0 self.completed = 0
def finish(self): def finish(self):
if self.progressBar: if self.progressBar:
self.progressBar.clear() self.progressBar.clear()
elif self.opts.quiet: elif self.opts.quiet:
pass pass
▲ Show 20 Lines • Show All 522 Lines • Show Last 20 Lines