This is an archive of the discontinued LLVM Phabricator instance.

[lit] Fix undefined symbol ArgumentError
ClosedPublic

Authored by modocache on Oct 9 2016, 1:59 PM.

Details

Summary

ArgumentError is not defined by the Python standard library.
Executing this line of code would throw a exception, but not the
intended one. It would throw a NameError exception, since ArgumentError
is undefined.

Use ValueError instead, which is defined by the Python standard
library.

Event Timeline

modocache updated this revision to Diff 74081.Oct 9 2016, 1:59 PM
modocache retitled this revision from to [lit] Fix undefined symbol ArgumentError.
modocache updated this object.
modocache added a subscriber: llvm-commits.
ddunbar accepted this revision.Oct 9 2016, 5:02 PM
ddunbar edited edge metadata.
This revision is now accepted and ready to land.Oct 9 2016, 5:02 PM
modocache closed this revision.Oct 9 2016, 6:28 PM