Page MenuHomePhabricator

Add a Chrono.h header to libSupport
AbandonedPublic

Authored by mehdi_amini on Oct 7 2016, 10:18 PM.

Details

Reviewers
zturner
labath
Summary

The intent is to add helpers (utility functions or wrapper)
to manipulate std::chrono types.

Event Timeline

mehdi_amini retitled this revision from to Add a Chrono.h header to libSupport.
mehdi_amini updated this object.
mehdi_amini added reviewers: labath, zturner.
mehdi_amini added a subscriber: llvm-commits.

Fix typo in doxygen comment

It should be worth noting that this is a straw man proposal to start a utility header to support the use of std::chrono in LLDB.
Also with the drop of MSVC2013, we should be table to slowly move away from TimeValue, unless it provides some other benefits that I missed?

labath edited edge metadata.Oct 8 2016, 4:55 PM

After studying the chrono library a bit more, I've learned of an easier way to do this, one that renders this function redundant (it's std::chrono::duration<double, std::milli (or whatever)>(value) if anyone wonders). Thank you for testing out the waters for me though :).

I'll soon come up with a proposal for adding conversions from/to the legacy types that we need to this header.

mehdi_amini abandoned this revision.Oct 10 2016, 9:07 AM

Superseded by: D25416: Add Chrono.h - std::chrono support header