This is an archive of the discontinued LLVM Phabricator instance.

Differential D25237

[ELF] - Do not crash on MIPS if there is no object files in input.
ClosedPublic

Authored by grimar on Oct 4 2016, 7:28 AM.

Details

Reviewers
ruiu
• rafael
atanasyan
Commits
rGe25253810771: [ELF] - Do not crash on MIPS if there is no object files in input.
rLLD283226: [ELF] - Do not crash on MIPS if there is no object files in input.
rL283226: [ELF] - Do not crash on MIPS if there is no object files in input.
Summary

If we have input without object files, for example if we have only .so
code will crash in
checkFlags(), getPicFlags(), getArchFlags() functions.

Patch fixes the issue.

Diff Detail

Event Timeline

grimar updated this revision to Diff 73476.Oct 4 2016, 7:28 AM
grimar retitled this revision from to [ELF] - Do not crash on MIPS if there is no object files in input..
grimar updated this object.
grimar added reviewers: atanasyan, ruiu, • rafael.
grimar added subscribers: llvm-commits, grimar, evgeny777.
Herald added a subscriber: sdardis. · View Herald TranscriptOct 4 2016, 7:28 AM
atanasyan accepted this revision.Oct 4 2016, 8:18 AM
atanasyan edited edge metadata.

LGTM

Thanks!

This revision is now accepted and ready to land.Oct 4 2016, 8:18 AM
Closed by commit rL283226: [ELF] - Do not crash on MIPS if there is no object files in input. (authored by grimar). · Explain WhyOct 4 2016, 8:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
ELF/
Mips.cpp
Mips.cpp (revision 283204)
2 lines
test/
ELF/
mips-no-objects.s
mips-no-objects.s (nonexistent)
5 lines

Diff 73476

ELF/Mips.cpp

Show First 20 Lines • Show All 279 Lines • ▼ Show 20 Linesstatic uint32_t getArchFlags(ArrayRef<FileFlags> Files) {
} }
return Ret; return Ret;
} }
template <class ELFT> uint32_t elf::getMipsEFlags() { template <class ELFT> uint32_t elf::getMipsEFlags() {
std::vector<FileFlags> V; std::vector<FileFlags> V;
for (elf::ObjectFile<ELFT> *F : Symtab<ELFT>::X->getObjectFiles()) for (elf::ObjectFile<ELFT> *F : Symtab<ELFT>::X->getObjectFiles())
V.push_back({F->getName(), F->getObj().getHeader()->e_flags}); V.push_back({F->getName(), F->getObj().getHeader()->e_flags});
if (V.empty())
return 0;
checkFlags(V); checkFlags(V);
return getMiscFlags(V) | getPicFlags(V) | getArchFlags(V); return getMiscFlags(V) | getPicFlags(V) | getArchFlags(V);
} }
static int compareMipsFpAbi(uint8_t FpA, uint8_t FpB) { static int compareMipsFpAbi(uint8_t FpA, uint8_t FpB) {
if (FpA == FpB) if (FpA == FpB)
return 0; return 0;
if (FpB == Mips::Val_GNU_MIPS_ABI_FP_ANY) if (FpB == Mips::Val_GNU_MIPS_ABI_FP_ANY)
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines

test/ELF/mips-no-objects.s

# REQUIRES: mips
# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o %t.o
# RUN: ld.lld %t.o -shared -o %t.so
# RUN: ld.lld %t.so -shared -o %t2.so
# RUN: llvm-readobj %t2.so > /dev/null 2>&1