Page MenuHomePhabricator

[compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64
ClosedPublic

Authored by etienneb on Sep 28 2016, 12:28 PM.

Details

Summary

On windows, the memcpy and memmove function can be the same.
This is correcly detected when hooking, but it's not possible
to report the right function name when doing symbolisation.

The same fix was applied for the static asan unittest.
We forgot to apply the fix for the dynamic asan tests.

lvm\projects\compiler-rt\test\asan/TestCases/Windows/.svn/text-base/intercept_memcpy.cc.svn-base:// CHECK-NEXT:  __asan_{{.*}}mem{{.*}}

This patch is fixing this test (win64):

ddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/dll_intercept_memcpy_indirect.cc

Diff Detail

Event Timeline

etienneb updated this revision to Diff 72878.Sep 28 2016, 12:28 PM
etienneb retitled this revision from to [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
vitalybuka accepted this revision.Sep 28 2016, 5:13 PM
vitalybuka added a reviewer: vitalybuka.
This revision is now accepted and ready to land.Sep 28 2016, 5:13 PM
etienneb closed this revision.Sep 30 2016, 7:38 AM