Page MenuHomePhabricator

[ELF] - Created new "Invalid" subfolder for testcases.
ClosedPublic

Authored by grimar on Sep 28 2016, 2:46 AM.

Details

Summary

This subfolder just like "linkerscript" subfolder keeps
testcases with invalid input. According to PR30540 it seems
we might have many new ones soon and I suggest to separate them
from regular testcases.

Diff Detail

Event Timeline

grimar updated this revision to Diff 72786.Sep 28 2016, 2:46 AM
grimar retitled this revision from to [ELF] - Created new "Invalid" subfolder for testcases..
grimar updated this object.
grimar added reviewers: ruiu, rafael, davide.
grimar added subscribers: llvm-commits, grimar, evgeny777.
davide edited edge metadata.Sep 28 2016, 7:40 AM

LGTM, thanks

emaste accepted this revision.Sep 28 2016, 7:44 AM
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Sep 28 2016, 7:44 AM
This revision was automatically updated to reflect the committed changes.

I also wonder if we want to move invalid-dse*.s and invalid-cie*.s tests into new folder. I did not do that because they do not use something special like yaml2obj or hexedited objects, so in my understanding it is hard to call them "invalid inputs".

ruiu edited edge metadata.Sep 28 2016, 12:49 PM

Please remove invalid from filenames if you move them under invalid directory.

Invalid directory should be invalid (starts with a lowercase).